Re: [PATCH 4/7] ath10k: wake up everything on core restart

[Michal Kazior <michal.kazior@tieto.com>]

On 15 May 2014 15:21, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> It makes sense to finish completions as they may
>> be waited for while holding conf_mutex thus
>> delaying hw restart.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> ---
>>  drivers/net/wireless/ath/ath10k/core.c | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
>> index 3f4d28f..bf7c323 100644
>> --- a/drivers/net/wireless/ath/ath10k/core.c
>> +++ b/drivers/net/wireless/ath/ath10k/core.c
>> @@ -709,6 +709,18 @@ void ath10k_core_restart(struct ath10k *ar)
>>       spin_lock_bh(&ar->data_lock);
>>       ar->wmi.drop = true;
>>       wake_up(&ar->wmi.tx_credits_wq);
>> +
>> +     complete(&ar->target_suspend);
>> +     complete(&ar->debug.event_stats_compl);
>
> We dropped this patchset already, but for the future, this patch
> introduces a new warning:
>
>    drivers/net/wireless/ath/ath10k/core.c: In function 'ath10k_core_restart':
>>> drivers/net/wireless/ath/ath10k/core.c:714:14: error: 'struct ath10k'
>>> has no member named 'debug'
>      complete(&ar->debug.event_stats_compl);
>                  ^

Good catch. I completely forgot ar->debug is inside an #ifdef DEBUG.


> Maybe that complete call should be in debug.c?

Well, either we add an ifdef here (core.c @ L714), or an ifdef in
debug.h + debug.c..


Michał