From: Ramon Fried <ramon.fried@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/6] wcn36xx: Increase number of TX retries
Date: Fri, 24 Jul 2020 16:43:10 +0300 [thread overview]
Message-ID: <CA+Kvs9mZ=7TtptfKmrapSqvsM=XeNuyUKJ6zbzgBQb9zHZjewA@mail.gmail.com> (raw)
In-Reply-To: <877dut5a60.fsf@codeaurora.org>
Yes. small glitch. sorry.
On Fri, Jul 24, 2020 at 4:12 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Ramon Fried <ramon.fried@gmail.com> writes:
>
> > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org>
> > wrote:
> >
> > Increase the short/long retry limit to 15 in order to impove TX
> > robustness in noisy/busy environment. 15 is the default value
> > defined in the downstream driver. Observed number of ack timeout
> > is reduced with this change.
> >
> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > ---
> > drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c
> > b/drivers/net/wireless/ath/wcn36xx/smd.c
> > index 59f9f53..908cc6c 100644
> > --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> > +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> > @@ -45,8 +45,8 @@ static struct wcn36xx_cfg_val wcn36xx_cfg_vals[]
> > = {
> > WCN36XX_CFG_VAL(MAX_MEDIUM_TIME, 6000),
> > WCN36XX_CFG_VAL(MAX_MPDUS_IN_AMPDU, 64),
> > WCN36XX_CFG_VAL(RTS_THRESHOLD, 2347),
> > - WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 6),
> > - WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 6),
> > + WCN36XX_CFG_VAL(SHORT_RETRY_LIMIT, 15),
> > + WCN36XX_CFG_VAL(LONG_RETRY_LIMIT, 15),
> > WCN36XX_CFG_VAL(FRAGMENTATION_THRESHOLD, 8000),
> > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ZERO, 5),
> > WCN36XX_CFG_VAL(DYNAMIC_THRESHOLD_ONE, 10),
> > --
> > 2.7.4
> >
> >
> >
> >
> > These set of patches fixed my connectivity issues with TP-Link DECO
> > routers.
> > Acked-By: Ramon Fried <rfried.dev@gmail.com>
>
> HTML emails are dropped by the list, please use text/plain only.
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-07-24 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 10:20 [PATCH v2 0/6] wcn36xx misc fixes Loic Poulain
2020-07-24 10:20 ` [PATCH v2 1/6] wcn36xx: Fix multiple AMPDU sessions support Loic Poulain
2020-08-14 15:02 ` Kalle Valo
2020-07-24 10:20 ` [PATCH v2 2/6] wcn36xx: Add TX ack support Loic Poulain
2020-07-24 10:20 ` [PATCH v2 3/6] wcn36xx: Increase number of TX retries Loic Poulain
[not found] ` <CA+Kvs9nZm+uoRJfjq33s1_nTbPt82NnEKmgYCWk0q5vH+-ca9w@mail.gmail.com>
2020-07-24 13:12 ` Kalle Valo
2020-07-24 13:43 ` Ramon Fried [this message]
2020-07-24 10:20 ` [PATCH v2 4/6] wcn36xx: Fix TX data path Loic Poulain
2020-07-24 10:20 ` [PATCH v2 5/6] wcn36xx: Fix software-driven scan Loic Poulain
2020-07-29 23:03 ` Bryan O'Donoghue
2020-08-14 14:50 ` Kalle Valo
2020-07-24 10:20 ` [PATCH v2 6/6] wcn36xx: Use sequence number allocated by mac80211 Loic Poulain
2020-07-24 13:47 ` [PATCH v2 0/6] wcn36xx misc fixes Ramon Fried
2020-07-24 14:02 ` Loic Poulain
2020-07-24 18:51 ` Ramon Fried
2020-07-28 10:13 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Kvs9mZ=7TtptfKmrapSqvsM=XeNuyUKJ6zbzgBQb9zHZjewA@mail.gmail.com' \
--to=ramon.fried@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).