* [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
@ 2020-04-17 7:45 Sedat Dilek
2020-04-17 8:03 ` Kalle Valo
2020-04-21 7:50 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Sedat Dilek @ 2020-04-17 7:45 UTC (permalink / raw)
To: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, Kalle Valo, David S. Miller,
linux-wireless, netdev, linux-kernel
Cc: Chris Rorvick, Sedat Dilek
From: Chris Rorvick <chris@rorvick.com>
Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
("iwlwifi: dbg: move debug data to a struct") but does not implement the
check correctly.
Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
Tweeted-by: @grsecurity
Message-Id: <20200402050219.4842-1-chris@rorvick.com>
Signed-off-by: Chris Rorvick <chris@rorvick.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
Changes v1->v2:
- Fix typo s/fw.dbg_conf_tlv/fw.dbg.conf_tlv
- Add Fixes tag as suggested by Kalle
- v2 on top of wireless-drivers.git as suggested by Kalle
Changes v2->v3:
- Add Changelog
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index ff52e69c1c80..eeb750bdbda1 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -1467,7 +1467,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
kmemdup(pieces->dbg_conf_tlv[i],
pieces->dbg_conf_tlv_len[i],
GFP_KERNEL);
- if (!pieces->dbg_conf_tlv[i])
+ if (!drv->fw.dbg.conf_tlv[i])
goto out_free_fw;
}
}
--
2.26.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
2020-04-17 7:45 [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer Sedat Dilek
@ 2020-04-17 8:03 ` Kalle Valo
2020-04-17 8:06 ` Sedat Dilek
2020-04-21 7:50 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2020-04-17 8:03 UTC (permalink / raw)
To: Sedat Dilek
Cc: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel, Chris Rorvick
Sedat Dilek <sedat.dilek@gmail.com> writes:
> From: Chris Rorvick <chris@rorvick.com>
>
> Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> check correctly.
>
> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> Tweeted-by: @grsecurity
> Message-Id: <20200402050219.4842-1-chris@rorvick.com>
> Signed-off-by: Chris Rorvick <chris@rorvick.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
really needed in this case.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
2020-04-17 8:03 ` Kalle Valo
@ 2020-04-17 8:06 ` Sedat Dilek
0 siblings, 0 replies; 5+ messages in thread
From: Sedat Dilek @ 2020-04-17 8:06 UTC (permalink / raw)
To: Kalle Valo
Cc: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel, Chris Rorvick
On Fri, Apr 17, 2020 at 10:03 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Sedat Dilek <sedat.dilek@gmail.com> writes:
>
> > From: Chris Rorvick <chris@rorvick.com>
> >
> > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> > ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> > check correctly.
> >
> > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> > Tweeted-by: @grsecurity
> > Message-Id: <20200402050219.4842-1-chris@rorvick.com>
> > Signed-off-by: Chris Rorvick <chris@rorvick.com>
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
> really needed in this case.
>
Thanks for all your suggestions and taking care, Kalle.
- Sedat -
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
2020-04-17 7:45 [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer Sedat Dilek
2020-04-17 8:03 ` Kalle Valo
@ 2020-04-21 7:50 ` Kalle Valo
2020-04-21 8:32 ` Sedat Dilek
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2020-04-21 7:50 UTC (permalink / raw)
To: Sedat Dilek
Cc: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel, Chris Rorvick, Sedat Dilek
Sedat Dilek <sedat.dilek@gmail.com> wrote:
> From: Chris Rorvick <chris@rorvick.com>
>
> Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> check correctly.
>
> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> Tweeted-by: @grsecurity
> Signed-off-by: Chris Rorvick <chris@rorvick.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Patch applied to wireless-drivers.git, thanks.
a176e114ace4 iwlwifi: actually check allocated conf_tlv pointer
--
https://patchwork.kernel.org/patch/11494331/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
2020-04-21 7:50 ` Kalle Valo
@ 2020-04-21 8:32 ` Sedat Dilek
0 siblings, 0 replies; 5+ messages in thread
From: Sedat Dilek @ 2020-04-21 8:32 UTC (permalink / raw)
To: Kalle Valo
Cc: Johannes Berg, Emmanuel Grumbach, Luca Coelho,
Intel Linux Wireless, David S. Miller, linux-wireless, netdev,
linux-kernel, Chris Rorvick
On Tue, Apr 21, 2020 at 9:50 AM Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> > From: Chris Rorvick <chris@rorvick.com>
> >
> > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> > ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> > check correctly.
> >
> > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> > Tweeted-by: @grsecurity
> > Signed-off-by: Chris Rorvick <chris@rorvick.com>
> > Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> Patch applied to wireless-drivers.git, thanks.
>
> a176e114ace4 iwlwifi: actually check allocated conf_tlv pointer
>
Thanks, Sedat.
> --
> https://patchwork.kernel.org/patch/11494331/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-21 8:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 7:45 [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer Sedat Dilek
2020-04-17 8:03 ` Kalle Valo
2020-04-17 8:06 ` Sedat Dilek
2020-04-21 7:50 ` Kalle Valo
2020-04-21 8:32 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).