archive mirror
 help / color / mirror / Atom feed
From: Sedat Dilek <>
To: Arend van Spriel <>
Cc: Kalle Valo <>,
	Linus Torvalds <>,
Subject: Re: [PATCH] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()
Date: Fri, 7 Jul 2017 14:47:03 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 7, 2017 at 2:01 PM, Arend van Spriel
<> wrote:
> The lower level nl80211 code in cfg80211 ensures that "len" is between
> 25 and NL80211_ATTR_FRAME (2304).  We subtract DOT11_MGMT_HDR_LEN (24) fr=
> "len" so thats's max of 2280.  However, the action_frame->data[] buffer i=
> only BRCMF_FIL_ACTION_FRAME_SIZE (1800) bytes long so this memcpy() can
> overflow.
>         memcpy(action_frame->data, &buf[DOT11_MGMT_HDR_LEN],
>                le16_to_cpu(action_frame->len));
> Reported-by: "freenerguo(=E9=83=AD=E5=A4=A7=E5=85=B4)" <freenerguo@tencen=>
> Signed-off-by: Arend van Spriel <>
> ---
> Hi Kalle,
> Here is the patch as Linus send it to us and I
> removed the lower bound check as that is already done in cfg80211.
> Now I signed off on the patch although formally I suppose Linus should
> sign it off. Putting it out there so people can respond as deemed
> necessary.
> Now fingers crossed whether patchwork will properly deal with the UTF-8
> characters :-p

Somehow horrific to see - less in usage (no CC here).

- Sedat -


  reply	other threads:[~2017-07-07 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-07 12:01 [PATCH] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx() Arend van Spriel
2017-07-07 12:47 ` Sedat Dilek [this message]
2017-07-07 19:39   ` Arend van Spriel
2017-07-12  9:59     ` Sedat Dilek
2017-07-07 13:17 ` Johannes Berg
2017-07-07 16:37   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).