From: Kan Yan <kyan@google.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org,
make-wifi-fast@lists.bufferbloat.net,
"Felix Fietkau" <nbd@nbd.name>,
"Yibo Zhao" <yiboz@codeaurora.org>
Subject: Re: [PATCH 1/2] mac80211: Implement Airtime-based Queue Limit (AQL)
Date: Wed, 9 Oct 2019 19:35:06 -0700 [thread overview]
Message-ID: <CA+iem5uemV7YB=DPry5UdgLgi0USXG-e3My2=3256EWtFkye4Q@mail.gmail.com> (raw)
In-Reply-To: <600f64e1e673fff25d2be71ac767d7332db0452a.camel@sipsolutions.net>
> I'd like to use the new rate calculation code that Felix added to mt76.
> Is the arsta->txrate info in ath10k suitable to be passed up to mac80211
> and used in that, do you think? Because then that would probably be the
> easiest way to go about it...
Do you mean the mt76 patch that using the EWMA to smooth estimate data
rate? It would be great if you can move that to mac80211.
Yes, arsta->txrate info in ath10k is a good place to extract latest date rate.
On Mon, Oct 7, 2019 at 12:43 PM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Mon, 2019-10-07 at 21:40 +0200, Toke Høiland-Jørgensen wrote:
>
> > > > So if and when we start supporting true multi-band devices we'll have to
> > > > change these things anyway. So might as well keep everything together so
> > > > it all gets fixed :)
> > >
> > > I guess I'm OK with that, but I'm pretty sure this will come up sooner
> > > rather than later ...
> > >
> > > What else is there though?
> >
> > By "it all" I meant "all the airtime fairness stuff". Other than that, I
> > didn't have anything in particular in mind. I just kinda assumed there
> > would be lots of places that had an implicit assumption that all devices
> > on the same phy shares a channel...
>
> Not _that_ much - we do have the channel contexts after all. But except
> for hwsim (*cough cough* I was lazy) nothing actually implements real
> concurrent multi-channel yet, obviously, but uses a single radio with
> channel hopping...
>
> johannes
>
next prev parent reply other threads:[~2019-10-10 2:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 6:21 [PATCH 0/2] Implement Airtime-based Queue Limit (AQL) Kan Yan
2019-10-04 6:21 ` [PATCH 1/2] mac80211: " Kan Yan
2019-10-04 12:30 ` Johannes Berg
2019-10-04 12:34 ` Johannes Berg
2019-10-04 15:44 ` Toke Høiland-Jørgensen
2019-10-05 2:08 ` Kan Yan
2019-10-05 2:19 ` Kan Yan
2019-10-06 17:40 ` Toke Høiland-Jørgensen
2019-10-07 19:23 ` Johannes Berg
2019-10-07 19:32 ` [Make-wifi-fast] " Dave Taht
2019-10-07 19:40 ` Toke Høiland-Jørgensen
2019-10-07 19:43 ` Johannes Berg
2019-10-10 2:35 ` Kan Yan [this message]
2019-10-04 6:21 ` [PATCH 2/2] ath10k: Enable " Kan Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+iem5uemV7YB=DPry5UdgLgi0USXG-e3My2=3256EWtFkye4Q@mail.gmail.com' \
--to=kyan@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@redhat.com \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).