From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Kalle Valo <kvalo@kernel.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] wifi: ath10k: support board-specific firmware overrides
Date: Mon, 12 Feb 2024 15:23:35 +0200 [thread overview]
Message-ID: <CAA8EJpratQH5fS9mS8mnK=c9FwHn8n8g5dj+weoyzrobVMOvBQ@mail.gmail.com> (raw)
In-Reply-To: <03d5d556-9477-4f2e-a737-c2f6a96d97a4@linaro.org>
On Mon, 12 Feb 2024 at 13:12, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 30.01.2024 17:38, Dmitry Baryshkov wrote:
> > Different Qualcomm platforms using WCN3990 WiFI chip use SoC-specific
> > firmware versions with different features. For example firmware for
> > SDM845 doesn't use single-chan-info-per-channel feature, while firmware
> > for QRB2210 / QRB4210 requires that feature. Allow board DT files to
> > override the subdir of the fw dir used to lookup the firmware-N.bin file
> > decribing corresponding WiFi firmware.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> > drivers/net/wireless/ath/ath10k/core.c | 11 ++++++++++-
> > drivers/net/wireless/ath/ath10k/core.h | 2 ++
> > drivers/net/wireless/ath/ath10k/snoc.c | 3 +++
> > 3 files changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> > index 0032f8aa892f..ef7ce8b3f8fb 100644
> > --- a/drivers/net/wireless/ath/ath10k/core.c
> > +++ b/drivers/net/wireless/ath/ath10k/core.c
> > @@ -942,11 +942,20 @@ static const struct firmware *ath10k_fetch_fw_file(struct ath10k *ar,
> > if (dir == NULL)
> > dir = ".";
> >
> > + if (ar->board_name) {
> > + snprintf(filename, sizeof(filename), "%s/%s/%s",
> > + dir, ar->board_name, file);
> > + ret = firmware_request_nowarn(&fw, filename, ar->dev);
> > + ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot fw request '%s': %d\n",
> > + filename, ret);
>
> Perhaps it'd be useful to move to a more noisy loglevel
No, these are details. If the firmware is in place, it is loaded properly.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2024-02-12 13:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 16:38 [PATCH RFC 0/4] wifi: ath10k: support board-specific firmware overrides Dmitry Baryshkov
2024-01-30 16:38 ` [PATCH RFC 1/4] dt-bindings: net: wireless: ath10k: describe firmware-name property Dmitry Baryshkov
2024-01-31 8:27 ` Krzysztof Kozlowski
2024-01-30 16:38 ` [PATCH RFC 2/4] wifi: ath10k: support board-specific firmware overrides Dmitry Baryshkov
2024-02-12 11:12 ` Konrad Dybcio
2024-02-12 13:23 ` Dmitry Baryshkov [this message]
2024-03-01 8:01 ` Kalle Valo
2024-01-30 16:38 ` [PATCH RFC 3/4] arm64: dts: qcom: qrb2210-rb1: add firmware-name qualifier to WiFi node Dmitry Baryshkov
2024-02-12 11:46 ` Konrad Dybcio
2024-01-30 16:38 ` [PATCH RFC 4/4] arm64: dts: qcom: qrb4210-rb1: " Dmitry Baryshkov
2024-02-12 11:46 ` Konrad Dybcio
2024-02-12 20:56 ` [PATCH RFC 0/4] wifi: ath10k: support board-specific firmware overrides Jeff Johnson
2024-02-19 22:23 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJpratQH5fS9mS8mnK=c9FwHn8n8g5dj+weoyzrobVMOvBQ@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=andersson@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).