From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: luciano.coelho@intel.com
Cc: Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dror Moshe <drorx.moshe@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Mordechay Goodstein <mordechay.goodstein@intel.com>,
Abhishek Naik <abhishek.naik@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Ayala Barazani <ayala.barazani@intel.com>,
Harish Mitty <harish.mitty@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: Increase microcodes loading timeout
Date: Mon, 13 Dec 2021 11:34:59 +0800 [thread overview]
Message-ID: <CAAd53p4v6BWSmd-4jNBs95y2Tf8TY1iedvgN=P_3nC3oa1_oTA@mail.gmail.com> (raw)
In-Reply-To: <20211203020931.1419572-1-kai.heng.feng@canonical.com>
On Fri, Dec 3, 2021 at 10:10 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Intel AX201/AX211 device may not work at boot:
> [ 8.875307] iwlwifi 0000:00:14.3: SecBoot CPU1 Status: 0x7267, CPU2 Status: 0xb03
> [ 8.875418] iwlwifi 0000:00:14.3: UMAC PC: 0x80481126
> [ 8.875426] iwlwifi 0000:00:14.3: LMAC PC: 0x1541c
> [ 8.875430] iwlwifi 0000:00:14.3: WRT: Collecting data: ini trigger 13 fired (delay=0ms).
> [ 8.877906] iwlwifi 0000:00:14.3: Loaded firmware version: 64.97bbee0a.0 so-a0-gf-a0-64.ucode
> ...
> [ 8.878997] iwlwifi 0000:00:14.3: Failed to start RT ucode: -110
> [ 8.878999] iwlwifi 0000:00:14.3: Failed to start RT ucode: -110
>
> Increase MVM_UCODE_ALIVE_TIMEOUT to 2 seconds can solve the issue.
>
> The PNVM loading can also fail:
> [ 5.159949] iwlwifi 0000:00:14.3: loaded PNVM version 4b50f925
> [ 5.414211] iwlwifi 0000:00:14.3: Timeout waiting for PNVM load!
> [ 5.414219] iwlwifi 0000:00:14.3: Failed to start RT ucode: -110
> [ 5.414224] iwlwifi 0000:00:14.3: WRT: Collecting data: ini trigger 13 fired (delay=0ms).
> [ 5.416618] iwlwifi 0000:00:14.3: Start IWL Error Log Dump:
> [ 5.416619] iwlwifi 0000:00:14.3: Transport status: 0x00000042, valid: 6
> [ 5.416620] iwlwifi 0000:00:14.3: Loaded firmware version: 64.97bbee0a.0 so-a0-gf-a0-64.ucode
> ...
> [ 5.914276] iwlwifi 0000:00:14.3: Failed to run INIT ucode: -110
>
> Trial and error shows that the MVM_UCODE_PNVM_TIMEOUT also needs to be
> bumped to 2 seconds to fully eliminate the issue.
>
> The timeout values are verified by rebooting over 10k times.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
A gentle ping...
> ---
> drivers/net/wireless/intel/iwlwifi/fw/pnvm.h | 2 +-
> drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h
> index 203c367dd4dee..b730330d8feac 100644
> --- a/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h
> +++ b/drivers/net/wireless/intel/iwlwifi/fw/pnvm.h
> @@ -10,7 +10,7 @@
>
> #include "fw/notif-wait.h"
>
> -#define MVM_UCODE_PNVM_TIMEOUT (HZ / 4)
> +#define MVM_UCODE_PNVM_TIMEOUT (2 * HZ)
>
> #define MAX_PNVM_NAME 64
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> index 6ce78c03e51f7..0c5375f7baecf 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> @@ -24,7 +24,7 @@
> #include "iwl-modparams.h"
> #include "iwl-nvm-parse.h"
>
> -#define MVM_UCODE_ALIVE_TIMEOUT (HZ)
> +#define MVM_UCODE_ALIVE_TIMEOUT (2 * HZ)
> #define MVM_UCODE_CALIB_TIMEOUT (2 * HZ)
>
> #define UCODE_VALID_OK cpu_to_le32(0x1)
> --
> 2.32.0
>
prev parent reply other threads:[~2021-12-13 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 2:09 [PATCH] iwlwifi: Increase microcodes loading timeout Kai-Heng Feng
2021-12-13 3:34 ` Kai-Heng Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAd53p4v6BWSmd-4jNBs95y2Tf8TY1iedvgN=P_3nC3oa1_oTA@mail.gmail.com' \
--to=kai.heng.feng@canonical.com \
--cc=abhishek.naik@intel.com \
--cc=ayala.barazani@intel.com \
--cc=davem@davemloft.net \
--cc=drorx.moshe@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=harish.mitty@intel.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=mordechay.goodstein@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).