From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ie0-f175.google.com ([209.85.223.175]:36522 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbbESXGF (ORCPT ); Tue, 19 May 2015 19:06:05 -0400 MIME-Version: 1.0 In-Reply-To: <20150519230355.GA5853@gondor.apana.org.au> References: <1430873070-7290-4-git-send-email-mcgrof@do-not-panic.com> <20150506033330.GA16470@gondor.apana.org.au> <1430988137.8171.58.camel@x220> <1431021995.8171.97.camel@x220> <20150518200100.GY23057@wotan.suse.de> <1431981930.9091.29.camel@x220> <20150519000921.GA23057@wotan.suse.de> <1432022535.9091.48.camel@x220> <20150519154630.GB23057@wotan.suse.de> <20150519225945.GB5718@gondor.apana.org.au> <20150519230355.GA5853@gondor.apana.org.au> From: "Luis R. Rodriguez" Date: Tue, 19 May 2015 16:05:43 -0700 Message-ID: (sfid-20150520_010624_004793_4DB43089) Subject: Re: [PATCH v1 03/12] crypto: qat - address recursive dependency when fw signing is enabled To: Herbert Xu Cc: Paul Bolle , Rusty Russell , David Howells , Ming Lei , Seth Forshee , Kyle McMartin , Andrew Morton , Greg Kroah-Hartman , Kees Cook , Casey Schaufler , Takashi Iwai , Matthew Garrett , "wireless-regdb@lists.infradead.org" , linux-wireless , jlee@suse.com, "linux-kernel@vger.kernel.org" , Bruce Allan , Tadeusz Struk , John Griffin Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, May 19, 2015 at 4:03 PM, Herbert Xu wrote: > OK I was wrong. It should still compile Right. > So I guess you only > need the depends on/select for those that won't work without the > firmware. Well that's be true if FW_LOADER was easy to disable, but its not. You really gotta try hard to disable it. Not only does it require EXPERT but also EMBEDDED. I think its fair to say if you disable FW_LOADER you know what you are doing and its fair for us then to remove such selects or depends. Thoughts? Luis