From: "Michał Kazior" <kazikcz@gmail.com>
To: Wen Gong <wgong@qti.qualcomm.com>
Cc: Wen Gong <wgong@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash
Date: Mon, 7 Jan 2019 09:35:43 +0100 [thread overview]
Message-ID: <CABvG-CWAfB8jjCDW4ggjJ8_YC++CjttJOMOt4s24F3mymvNR9A@mail.gmail.com> (raw)
In-Reply-To: <195f3bb0c88c43a6b1ca0ad336f947c0@aptaiexm02f.ap.qualcomm.com>
On Mon, 7 Jan 2019 at 08:16, Wen Gong <wgong@qti.qualcomm.com> wrote:
>
> > > It is because the state has not changed to ATH10K_STATE_ON
> > > immediately, then it will have more than two simulate crash process
> > > running meanwhile, and complete/wakeup some field twice, it destroy
> > > the normal recovery process.
> >
> > This was intended to allow testing not only firmware crash path (and
> > recovery) but also firmware crash while recovering from a firmware crash.
> >
> If firmware is recovering from crash, then simulate a new crash will trigger error.
> So remove it.
That's actually a feature, not a bug. If firmware crashes while driver
is restarting after a crash then its likely going to fail again and
again causing a crash-restart loop which can affect system performance
and responsiveness. It's better to give up and let the system admin
take over.
If it's still bothering you then please consider a crash counter
threshold so that, e.g. after 5 crash-while-restarting it's going to
give up. However I doubt it's worth the effort. My experience tells me
firmware crashes during recovery are rarely, if at all, transient.
The simulated fw crash is not representative here. It's a mere tool to
test driver code.
Michał
next prev parent reply other threads:[~2019-01-07 8:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 2:50 [PATCH] ath10k: Remove ATH10K_STATE_RESTARTED in simulate fw crash Wen Gong
2018-11-14 7:48 ` Michał Kazior
2019-01-07 7:16 ` Wen Gong
2019-01-07 8:35 ` Michał Kazior [this message]
2019-01-08 8:45 ` Wen Gong
2019-02-08 13:32 ` Kalle Valo
2019-02-08 13:34 ` Kalle Valo
2019-04-01 6:11 ` Wen Gong
2019-04-08 10:19 ` Wen Gong
2019-04-08 17:27 ` Michał Kazior
2019-04-09 5:09 ` Wen Gong
2019-04-09 23:25 ` Brian Norris
2019-04-10 2:45 ` Wen Gong
2019-05-28 2:49 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABvG-CWAfB8jjCDW4ggjJ8_YC++CjttJOMOt4s24F3mymvNR9A@mail.gmail.com \
--to=kazikcz@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
--cc=wgong@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).