From: "Rafał Miłecki" <zajec5@gmail.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"Winnie Chang" <winnie.chang@cypress.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER
<brcm80211-dev-list.pdl@broadcom.com>,"
<brcm80211-dev-list@cypress.com>,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/3] brcmfmac: move "cfg80211_ops" pointer to another struct
Date: Mon, 9 Sep 2019 15:15:20 +0200 [thread overview]
Message-ID: <CACna6ry4TXRQb4Ls1TSccKLDrNictuk3HNQf7LKp6C-=DJTbVw@mail.gmail.com> (raw)
In-Reply-To: <527c6f46-bad4-58ac-afce-ca62ddda7c5b@broadcom.com>
On Tue, 3 Sep 2019 at 20:59, Arend Van Spriel
<arend.vanspriel@broadcom.com> wrote:
> On 9/3/2019 6:29 AM, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > This moves "ops" pointer from "struct brcmf_cfg80211_info" to the
> > "struct brcmf_pub". This movement makes it possible to allocate wiphy
> > without attaching cfg80211 (brcmf_cfg80211_attach()). It's required for
> > later separation of wiphy allocation and driver initialization.
> >
> > While at it fix also an unlikely memory leak in the brcmf_attach().
>
> Always good ;-)
>
> I recall there is some fiddling with the callback ops in cfg80211.c. Is
> that broken by this reorg. Need to look into that.
I don't see how this patch could break that. It still calls
brcmf_cfg80211_get_ops() and passes settings as an argument.
--
Rafał
next prev parent reply other threads:[~2019-09-09 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 4:29 [PATCH 0/3] brcmfmac: keep wiphy during PCIe driver lifetime Rafał Miłecki
2019-09-03 4:29 ` [PATCH 1/3] brcmfmac: move "cfg80211_ops" pointer to another struct Rafał Miłecki
2019-09-03 18:59 ` Arend Van Spriel
2019-09-09 13:15 ` Rafał Miłecki [this message]
2019-09-13 13:42 ` Kalle Valo
2019-09-03 4:29 ` [PATCH 2/3] brcmfmac: split brcmf_attach() and brcmf_detach() functions Rafał Miłecki
2019-09-03 19:03 ` Arend Van Spriel
2019-09-03 4:29 ` [PATCH 3/3] brcmfmac: don't realloc wiphy during PCIe reset Rafał Miłecki
2019-09-03 19:04 ` Arend Van Spriel
2019-09-03 18:51 ` [PATCH 0/3] brcmfmac: keep wiphy during PCIe driver lifetime Arend Van Spriel
2019-09-09 13:06 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACna6ry4TXRQb4Ls1TSccKLDrNictuk3HNQf7LKp6C-=DJTbVw@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=winnie.chang@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).