From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED45AC433ED for ; Thu, 6 May 2021 22:57:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE304600D4 for ; Thu, 6 May 2021 22:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231300AbhEFW6O (ORCPT ); Thu, 6 May 2021 18:58:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230283AbhEFW6N (ORCPT ); Thu, 6 May 2021 18:58:13 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4E89C061574 for ; Thu, 6 May 2021 15:57:14 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id u21so10638936ejo.13 for ; Thu, 06 May 2021 15:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uLdKGXmtZv4WOuhm8GJ7l80lpB4+OjgqxObqMF2doJs=; b=olQg5p0yjDBdujSQAJeptHdz7B978JcsgXB9UIBSNoFK5KCqy+qN+4Gt+hKbnHJwK7 GQfwYyNIi+Uz3YrbHHF+nj3Dc3XdPffsmjkoXLl1kkaeV7EzetPFMjTizg05TSYSzviW s47efjQQhDT3RVUekS5jUEIQc35IBuFDtzc/gfDS5ohqqYZ3uSeMvQGKsdnK1MIdH/Tm NFFKYdsLhUflgltsCMpTX/lDAFz+3Y+N1sQW4axEkG5HTyEVhuOh8goZ6/WXevnPsXsx Sgy5PpKo2vSWRC559RcC0O8QgK7UXvUvTtQn1/hUaEMWBnyXkOIyXIsXuAtw6F+vQmOe H61w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uLdKGXmtZv4WOuhm8GJ7l80lpB4+OjgqxObqMF2doJs=; b=OF5VsmIZl5JUugLOiitDVDZBSkCDvu+Mw9ap+/2ir2VjhGeclLE22PzO42b1AKTpd7 fr0tRTbbtkyXuLXd65St3bDAfwx/RuqKN+JxiecnuWODALXTcbvh++C7X/Ue+8pl6Hm1 qJonAgUO+hDToi4UUiW1eQcXTdpM/Ba0Dn3+8vlvco61wgv6R9MIiFob4Jm1HIwgFHZ/ ZmiiBEpTjcf1FanDQrm1C7Qd/3fpmrfpuRkbse6gsHjQgSlnBPyzwoRsSz2dNBYn2NVd upjidBBsS4uIDTLpm0y8ITmEOhQ1oyZYuq/u0CChxazogxGMbJ/9S0VAm9O6BF1gI1bl CoNw== X-Gm-Message-State: AOAM530OLxXFzq/oyhZY+dllKfZcs4R75ujXRY7KGpZ/yBBgWdcl+elZ fKno5RYt8dh5XT8lc4NZYNdDJBMTd1UjLHuWKRwrjg== X-Google-Smtp-Source: ABdhPJx6sMOvb6H5iHbspfXj0fUHVG8/SxmDU8i4ZBrPKGpv38LFo9MPmmLJUfQXrmER+EiMNK2dVF1dMoWrHOgOKTs= X-Received: by 2002:a17:906:4a55:: with SMTP id a21mr6616986ejv.215.1620341833273; Thu, 06 May 2021 15:57:13 -0700 (PDT) MIME-Version: 1.0 References: <20210506180530.3418576-1-wdu@google.com> <285a8ab279d5ac6caa6e44d808ec2b0ae134bc1e.camel@sipsolutions.net> In-Reply-To: <285a8ab279d5ac6caa6e44d808ec2b0ae134bc1e.camel@sipsolutions.net> From: Weilun Du Date: Thu, 6 May 2021 15:57:02 -0700 Message-ID: Subject: Re: [PATCH v1] mac80211_hwsim: add concurrent channels scanning support over virtio To: Johannes Berg Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , kernel-team@android.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, May 6, 2021 at 2:13 PM Johannes Berg wrote: > > On Thu, 2021-05-06 at 14:11 -0700, Weilun Du wrote: > > On Thu, May 6, 2021 at 11:19 AM Johannes Berg wrote: > > > > > > On Thu, 2021-05-06 at 11:05 -0700, Weilun Du wrote: > > > > This fixed the crash when setting channels to 2 or more when > > > > communicating over virtio. > > > > > > Interesting, I thought I was probably the only user of virtio? :) > > > > > > johannes > > > > > Hi Johannes, > > Actually, Android Emulator uses mac80211_hwsim for wifi simulation > > over virtio and it's working. This patch fixed the crash when we set > > channels=2 to speed up scanning. I am trying to see if it makes sense > > to upstream this patch since it's not Android-specific. Thanks! > > > Oh sure, I'll take a look and will probably apply it for the next cycle, > haven't done an in-depth review. I was just surprised somebody actually > *used* the virtio thing :-) > > Does that mean virt_wifi isn't used anymore by the Android emulator? > Maybe then we should remove that again, it had some obscure bugs that > syzkaller found? Not that I mind it being around much, but ... > > johannes > Thanks for looking into it. Actually, virt_wifi is still in use. There are two different emulators that target different use cases. Android emulator (goldfish) is mainly for third-party app developers. But yes eventually, we are going to converge the Wi-Fi solution.