From: Daniel Drake <drake@endlessm.com>
To: Tony Chuang <yhchuang@realtek.com>
Cc: "Ján Veselý" <jano.vesely@gmail.com>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"gojun077@gmail.com" <gojun077@gmail.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"linux@endlessm.com" <linux@endlessm.com>
Subject: Re: [PATCH v2] rtw88: pci: enable MSI interrupt
Date: Mon, 2 Sep 2019 11:13:28 +0800 [thread overview]
Message-ID: <CAD8Lp46djFdVmifZn-CovgjFURAbbaeeBuc21hd1v0He071kUw@mail.gmail.com> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D18C1ABF@RTITMBSVM04.realtek.com.tw>
On Mon, Sep 2, 2019 at 11:02 AM Tony Chuang <yhchuang@realtek.com> wrote:
> Indeed it is a little strange but it works like that, if I don't disable HIMR,
> interrupt could be lost and never gets into interrupt handler again.
> If so, the interrupt will be stopped, and TX/RX path will be freezed.
OK, thanks for checking & explaining.
It's a bit hard to put in words as we have seen, but it would be good
if you could try to summarise this unusual design in the commit
message or in a code comment.
Thanks!
Daniel
prev parent reply other threads:[~2019-09-02 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 8:28 [PATCH v2] rtw88: pci: enable MSI interrupt yhchuang
2019-08-23 6:37 ` Daniel Drake
2019-08-23 7:22 ` Ján Veselý
2019-08-27 12:11 ` Tony Chuang
2019-08-27 13:02 ` Jian-Hong Pan
2019-08-28 7:04 ` Daniel Drake
2019-09-02 3:02 ` Tony Chuang
2019-09-02 3:13 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD8Lp46djFdVmifZn-CovgjFURAbbaeeBuc21hd1v0He071kUw@mail.gmail.com \
--to=drake@endlessm.com \
--cc=briannorris@chromium.org \
--cc=gojun077@gmail.com \
--cc=jano.vesely@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).