From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E18FC04AAC for ; Mon, 20 May 2019 18:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DD12208C3 for ; Mon, 20 May 2019 18:20:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oYB6QTOA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727441AbfETSUi (ORCPT ); Mon, 20 May 2019 14:20:38 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:32909 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbfETSUi (ORCPT ); Mon, 20 May 2019 14:20:38 -0400 Received: by mail-vk1-f194.google.com with SMTP id v69so4121857vke.0 for ; Mon, 20 May 2019 11:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cEsXYaOHHpFfqvOIf/R9j2mgz7hkA3ZSG0hiHjJfsfQ=; b=oYB6QTOAyrW+xrurBLaMKPFnUo9r8uSNIw0B5/zqa2y0TSIR3nr+FiEhLSwmdmx4XT PSW8n6oIFIvgbr1Q8u1FLhEjC2pMWGPcFrxz9D/vDnrjHb6YxdngV4/rsvj4XVMkiS7u zji43e+I4SpiwFIfKB7pf85C9sv2FuOd9EGRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cEsXYaOHHpFfqvOIf/R9j2mgz7hkA3ZSG0hiHjJfsfQ=; b=AL2hsAh98fBu1FqHn5XIsa9e1sTueq8JpuQtfM6FJnRI34XPAtb+Sexfofk6k1jGpx 5A6kn34utp6bMcM5DLRI2MwxQ1A91vid5gfFdCs/Y6hj/IKLU44D5FROwEwcat/xTR5N 81au/IbvDxHr5T2FpsI4Yj/owwLHbLJjRGtO3Rtw9HkN1MoFKI+AoSixwdNGTDhl5Gwe H1ps2s1T0KqmSfUNWuNlqAunXxEIj0a/VxTDdn/fA67Y8NnP9AK5UtrN60btw/J6qSWQ zaCjATA3itXH+JRd0z1RRIG7P9VLuZjFm9Z4tCdmueW+rvpDNyUK61ElhWefOx8cxOny jvqg== X-Gm-Message-State: APjAAAWrixx+l2zsamN4df0QbZ6u5bXdydKBv9N1FgIB9VZ+gppAJE4x ZVdu0DV3v9gyFr04q/GtAgz2X7AFXNo= X-Google-Smtp-Source: APXvYqz4PSx/3RMjjagmkae4lID0e87xHDdIVQWI2+Odzu+zDOZzXwvx82Imr95F+QPQfrTl8QApZQ== X-Received: by 2002:ac5:c194:: with SMTP id z20mr8651849vkb.54.1558376436713; Mon, 20 May 2019 11:20:36 -0700 (PDT) Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com. [209.85.222.49]) by smtp.gmail.com with ESMTPSA id w79sm6027401vkd.28.2019.05.20.11.20.34 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 11:20:34 -0700 (PDT) Received: by mail-ua1-f49.google.com with SMTP id 94so5628210uam.3 for ; Mon, 20 May 2019 11:20:34 -0700 (PDT) X-Received: by 2002:a9f:24a3:: with SMTP id 32mr13553176uar.109.1558376433588; Mon, 20 May 2019 11:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20190517225420.176893-1-dianders@chromium.org> <20190517225420.176893-2-dianders@chromium.org> In-Reply-To: From: Doug Anderson Date: Mon, 20 May 2019 11:20:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] brcmfmac: re-enable command decode in sdio_aos for BRCM 4354 To: Arend Van Spriel Cc: Ulf Hansson , Kalle Valo , Adrian Hunter , "open list:ARM/Rockchip SoC..." , Double Lo , Brian Norris , Madhan Mohan R , Matthias Kaehlcke , Wright Feng , Chi-Hsien Lin , brcm80211-dev-list.pdl@broadcom.com, Franky Lin , netdev , linux-wireless , LKML , Hante Meuleman , Naveen Gupta , brcm80211-dev-list@cypress.com, YueHaibing , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, On Mon, May 20, 2019 at 1:09 AM Arend Van Spriel wrote: > > On 5/18/2019 12:54 AM, Douglas Anderson wrote: > > In commit 29f6589140a1 ("brcmfmac: disable command decode in > > sdio_aos") we disabled something called "command decode in sdio_aos" > > for a whole bunch of Broadcom SDIO WiFi parts. > > > > After that patch landed I find that my kernel log on > > rk3288-veyron-minnie and rk3288-veyron-speedy is filled with: > > brcmfmac: brcmf_sdio_bus_sleep: error while changing bus sleep state -110 > > > > This seems to happen every time the Broadcom WiFi transitions out of > > sleep mode. Reverting the part of the commit that affects the WiFi on > > my boards fixes the problem for me, so that's what this patch does. > > This sounds very similar to the issue we had during integration of wifi > on rk3288 chromebooks years ago. I'm working on those same Chromebooks. ;-) I'm working on trying to make them well on newer kernels. ...but I guess you're saying that the problem faced by the people who wanted commit 29f6589140a1 ("brcmfmac: disable command decode in sdio_aos") are similar to the problems we saw in the past on those Chromebooks. I'd tend to agree. In general it's difficult to get a SD Host Controller to be fully robust in the fact of any/all errors on the bus. While dw_mmc is pretty robust these days I'm assuming that some other host controllers aren't. > > Note that, in general, the justification in the original commit seemed > > a little weak. It looked like someone was testing on a SD card > > controller that would sometimes die if there were CRC errors on the > > bus. This used to happen back in early days of dw_mmc (the controller > > on my boards), but we fixed it. Disabling a feature on all boards > > just because one SD card controller is broken seems bad. ...so > > instead of just this patch possibly the right thing to do is to fully > > revert the original commit. > > I am leaning towards a full revert, but let's wait for more background info. I'd be fine with a full revert too. Presumably that will break someone but maybe they need to come up with a better solution? -Doug