From: Doug Anderson <dianders@chromium.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: ath10k@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing
Date: Fri, 26 Jun 2020 14:37:46 -0700 [thread overview]
Message-ID: <CAD=FV=V_ynwukeR92nbJXkuQ7OAW4mLaTjxko7fXt5aEfDUNhA@mail.gmail.com> (raw)
In-Reply-To: <1593193967-29897-1-git-send-email-pillair@codeaurora.org>
Hi,
On Fri, Jun 26, 2020 at 10:53 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
> Currently the NAPI processing loops through all
> the copy engines and processes a particular copy
> engine is the copy completion is set for that copy
> engine. The host driver is not supposed to access
> any copy engine register after clearing the interrupt
> status register.
>
> This might result in kernel crash like the one below
> [ 1159.220143] Call trace:
> [ 1159.220170] ath10k_snoc_read32+0x20/0x40 [ath10k_snoc]
> [ 1159.220193] ath10k_ce_per_engine_service_any+0x78/0x130 [ath10k_core]
> [ 1159.220203] ath10k_snoc_napi_poll+0x38/0x8c [ath10k_snoc]
> [ 1159.220270] net_rx_action+0x100/0x3b0
> [ 1159.220312] __do_softirq+0x164/0x30c
> [ 1159.220345] run_ksoftirqd+0x2c/0x64
> [ 1159.220380] smpboot_thread_fn+0x1b0/0x288
> [ 1159.220405] kthread+0x11c/0x12c
> [ 1159.220423] ret_from_fork+0x10/0x18
>
> To avoid such a scenario, we generate an interrupt
> summary by reading the copy completion for all the
> copy engine before actually processing any of them.
> This will avoid reading the interrupt status register
> for any CE after the interrupt status is cleared.
>
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath10k/ce.c | 63 ++++++++++++++++++++++--------------
> drivers/net/wireless/ath/ath10k/ce.h | 5 +--
> 2 files changed, 42 insertions(+), 26 deletions(-)
I'm not an expert on this driver, but your change seems sane to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
With your patch I can no longer find a place to put in a magic delay
and reproduce the crash, thus:
Tested-by: Douglas Anderson <dianders@chromium.org>
If it matters, my WiFi firmware reports this:
WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1
...and it should also be WCN3990.
-Doug
next prev parent reply other threads:[~2020-06-26 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 17:52 [PATCH] ath10k: Add interrupt summary based CE processing Rakesh Pillai
2020-06-26 21:37 ` Doug Anderson [this message]
2020-06-26 21:49 ` Doug Anderson
2020-06-26 21:52 ` Brian Norris
2020-07-16 6:38 ` Kalle Valo
2020-07-21 0:33 ` Peter Oh
2020-07-21 0:40 ` Doug Anderson
2020-07-21 0:43 ` Peter Oh
[not found] ` <CALhWmc1B0+SONV6_AF+nUzgxZdekPD3sZuhrsmwVQx1Q-cgT_g@mail.gmail.com>
2020-07-21 0:56 ` Peter Oh
2020-07-21 0:58 ` Peter Oh
2020-07-21 1:32 ` Peter Oh
2020-07-21 11:24 ` Rakesh Pillai
2020-08-26 14:43 ` Kalle Valo
2020-08-26 14:54 ` Doug Anderson
2020-07-21 15:37 ` Doug Anderson
2020-09-01 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V_ynwukeR92nbJXkuQ7OAW4mLaTjxko7fXt5aEfDUNhA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).