From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D02C76186 for ; Wed, 24 Jul 2019 20:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA2872081B for ; Wed, 24 Jul 2019 20:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="emPr0+o1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391386AbfGXUWi (ORCPT ); Wed, 24 Jul 2019 16:22:38 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:45992 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390815AbfGXUWh (ORCPT ); Wed, 24 Jul 2019 16:22:37 -0400 Received: by mail-io1-f66.google.com with SMTP id g20so92342299ioc.12 for ; Wed, 24 Jul 2019 13:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W7b98j1DYhcpfb7OdCLFp27JFdB3a34V6jagTpBUbfA=; b=emPr0+o12gzDRDVdDGCZkDSc1awT8Sv7j4Y3PHnjX6+BEM8Ev916Ml6Ya5Ixn59rnj bYHRVD4vJpGgnK8uA8ZfT2527Pza1HUFVITP04fOwvVSTVtDbOhp0XyRD+J1U8RCZ7+q cQkjHaLlnu1CLlhPM31Ij364/ILIXnU5UveYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W7b98j1DYhcpfb7OdCLFp27JFdB3a34V6jagTpBUbfA=; b=Gx1q1HT6h8FrB0KUc8C/9iBRbwLg2jsONsSiB5NdVoY/fwIBZGtmUHCs5tFnoMiq9E WEeHPhiAS5AGqG01erqatgpFLWGo4ZPedC8vsytWQ/6G1QyFr/2oNiYq9ysO3KFn42bV yDtcJJHgGQ53MkBKv0/cRW3umv4QEMGQ3tf3GMeRBVUTDhc8k33fOOdzB5TIthD2WvdD 8TQPVN+Qf7xJ5yhCyBNhrqfhEfozOxBgpbFxTc+umv5srj6zWU8I+KOLpjaMit1ZlROE MDWRSaO++0XByhV0eAptf19bssEFscHqRsirUoR0hvWIECg+Z4o0/W50mwbO56ZJLWh3 XSig== X-Gm-Message-State: APjAAAWcZJTis+MuSn9A/Ct8qmZKHD7BfYiO2Zl8Lbz4GzMKvh6iQbPe wgyvLZTnul4hcJIhk9Nj4hHD9owCLYk= X-Google-Smtp-Source: APXvYqyGOa9rY/7GFMBmJ2C20MjRX4avKay4XQCGiE1p98KUI726X/Ey3zs6VN/swEleXvrw5wffeQ== X-Received: by 2002:a6b:7606:: with SMTP id g6mr23710188iom.288.1563999755964; Wed, 24 Jul 2019 13:22:35 -0700 (PDT) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com. [209.85.166.46]) by smtp.gmail.com with ESMTPSA id z19sm58366418ioh.12.2019.07.24.13.22.34 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 13:22:35 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id i10so92298289iol.13 for ; Wed, 24 Jul 2019 13:22:34 -0700 (PDT) X-Received: by 2002:a5d:8ccc:: with SMTP id k12mr78564964iot.141.1563999754524; Wed, 24 Jul 2019 13:22:34 -0700 (PDT) MIME-Version: 1.0 References: <20190722193939.125578-3-dianders@chromium.org> <20190724113508.47A356021C@smtp.codeaurora.org> In-Reply-To: <20190724113508.47A356021C@smtp.codeaurora.org> From: Doug Anderson Date: Wed, 24 Jul 2019 13:22:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] mwifiex: Make use of the new sdio_trigger_replug() API to reset To: Kalle Valo , Ulf Hansson Cc: Adrian Hunter , Ganapathi Bhat , linux-wireless , Andreas Fenkart , Brian Norris , Amitkumar Karwar , "open list:ARM/Rockchip SoC..." , Wolfram Sang , Nishant Sarmukadam , netdev , Avri Altman , Linux MMC List , David Miller , Xinming Hu , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, On Wed, Jul 24, 2019 at 4:35 AM Kalle Valo wrote: > > Douglas Anderson wrote: > > > As described in the patch ("mmc: core: Add sdio_trigger_replug() > > API"), the current mwifiex_sdio_card_reset() is broken in the cases > > where we're running Bluetooth on a second SDIO func on the same card > > as WiFi. The problem goes away if we just use the > > sdio_trigger_replug() API call. > > > > NOTE: Even though with this new solution there is less of a reason to > > do our work from a workqueue (the unplug / plug mechanism we're using > > is possible for a human to perform at any time so the stack is > > supposed to handle it without it needing to be called from a special > > context), we still need a workqueue because the Marvell reset function > > could called from a context where sleeping is invalid and thus we > > can't claim the host. One example is Marvell's wakeup_timer_fn(). > > > > Cc: Andreas Fenkart > > Cc: Brian Norris > > Fixes: b4336a282db8 ("mwifiex: sdio: reset adapter using mmc_hw_reset") > > Signed-off-by: Douglas Anderson > > Reviewed-by: Brian Norris > > I assume this is going via some other tree so I'm dropping this from my > queue. If I should apply this please resend once the dependency is in > wireless-drivers-next. > > Patch set to Not Applicable. Thanks. For now I'll assume that Ulf will pick it up if/when he is happy with patch #1 in this series. Would you be willing to provide your Ack on this patch to make it clear to Ulf you're OK with that? -Doug