From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797DFC43215 for ; Wed, 27 Nov 2019 22:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50F90215F1 for ; Wed, 27 Nov 2019 22:21:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RQP5pXqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbfK0WVt (ORCPT ); Wed, 27 Nov 2019 17:21:49 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:46422 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbfK0WVt (ORCPT ); Wed, 27 Nov 2019 17:21:49 -0500 Received: by mail-qt1-f193.google.com with SMTP id r20so26951621qtp.13; Wed, 27 Nov 2019 14:21:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=otxiMd0l6riNdSE7OSItmdvrSBc8N+W+v/4nkIlyazQ=; b=RQP5pXqwzoUtskHrYAlwr97uAnCC7oisEf/vhz6/+mD8Anotr29Jmbcp1OsIe69Tuw 0A07pM9BToSi1HQ9CxaWvtHPrghDyMPuemOfZhM2321xX9KmeiVxgiSnjUQIBsLeRS4o R9zvEDph33VWXPQAgQ4LGvSjFr4epgCXz2F2PJuCxiJnRYBb10J8fD2mPSzpKza4punW KbLTS5b3XmLY2fhyyoBCxBSo0g3mhVqKolxzp1FUvnnCSMNNR99KoyiIv14Y9OINZM7S 89OBRM3zJh807xtlqHssY5KwD+AZu1k/hOks+ORgzTRPddjl7piKvJVo9wVFBsy2e3FC pKHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=otxiMd0l6riNdSE7OSItmdvrSBc8N+W+v/4nkIlyazQ=; b=VjQ/9UrivBSw+tUuaHjexuzNHGhWbAip6WKw5wuh7Q6hSLpFvoyIdPj7yOq1xbz9A7 bD+C/WdoxTD8hV2WmSeX+mlkc/HPQrSow9dgKnHmpFvOxu8MnNcL8JdY4bjPP2eI5sZD srmXDsJ1DWAF2FEKqLwsFm3tatjf9mscsRO+RhW1ZHfoPzFYPT0GFt3V2HwP5OXQ4vKE 99g/6BhrvD+V6uSnANS86dSIjvcCFggM0ZP6jCsWTH9oLZVIkDFQXut0QIVwaKOE8WUz FP0vT7GF9xDgJD0/UJZCVZ/Rb085AsX7tCxi+NH4/dpzmQVrLW1rJz40GZ3EKKB7M0MT GjeQ== X-Gm-Message-State: APjAAAUrcWZdQhIgRkOLK1z6qDuc2wNVSetAo2fB9LfZ6wsvMeriP+wo +OrYGY4AoJc/hxPuvbIAedNaZC39o0YOCXEHKsk= X-Google-Smtp-Source: APXvYqy0F9gnB7YBK+zsp8V0IkP9CmjbBRcRUX0suieWlH88wWb+/2l2kHHjCnezybi9Y5JCjvlUe8cugNRtcIy1mP0= X-Received: by 2002:ac8:2b86:: with SMTP id m6mr10619893qtm.190.1574893307208; Wed, 27 Nov 2019 14:21:47 -0800 (PST) MIME-Version: 1.0 References: <20191127054358.GA59549@LGEARND20B15> <46dfe877-4f32-b763-429f-7af3a83828f0@cogentembedded.com> <0101016ead12c253-18d4624e-98eb-4252-ba3a-fabf74d831f2-000000@us-west-2.amazonses.com> In-Reply-To: <0101016ead12c253-18d4624e-98eb-4252-ba3a-fabf74d831f2-000000@us-west-2.amazonses.com> From: Austin Kim Date: Thu, 28 Nov 2019 07:21:40 +0900 Message-ID: Subject: Re: [PATCH] brcmsmac: Remove always false 'channel < 0' statement To: Kalle Valo Cc: Sergei Shtylyov , arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, davem@davemloft.net, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 2019=EB=85=84 11=EC=9B=94 27=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 10:35,= Kalle Valo =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > Austin Kim writes: > > > 2019=EB=85=84 11=EC=9B=94 27=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 7:= 48, Sergei Shtylyov > > =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84= =B1: > >> > >> On 27.11.2019 8:43, Austin Kim wrote: > >> > >> > As 'channel' is declared as u16, the following statement is always f= alse. > >> > channel < 0 > >> > > >> > So we can remove unnecessary 'always false' statement. > >> > >> It's an expression, not a statement. > >> > > > > According to below link, it is okay to use 'statement' in above case. > > https://en.wikipedia.org/wiki/Statement_(computer_science) > > I don't have time to start arguing about this, and I'm no C language > lawyer either, but all I say is that I agree with Sergei here. Thanks for your opinion. I will use 'expression' rather than 'statement' when I upstream similar patch later. > > > Why don't you show your opition about patch rather than commit message? > > But this comment is not ok. Patch review (including commit logs) is the > core principle of upstream development so you need to have an open mind > for all comments, even the ones you don't like. Oh! I Agreed. If I were you, I would leave similar comment. Thanks, Austin Kim > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa= tches