From: James Hughes <james.hughes@raspberrypi.org>
To: Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list@broadcom.com"
<brcm80211-dev-list@broadcom.com>,
brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <Wright.Feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Double Lo <Double.Lo@cypress.com>
Subject: Re: [PATCH 1/2] brcmfmac: fix system warning message during wowl suspend
Date: Thu, 3 Jan 2019 09:56:14 +0000 [thread overview]
Message-ID: <CAE_XsM+mdHkwMF3PEimVJBpLd=oMmuvK1uDdA7y8uJT8hYNfbA@mail.gmail.com> (raw)
In-Reply-To: <1546501565-40752-2-git-send-email-chi-hsien.lin@cypress.com>
On Thu, 3 Jan 2019 at 07:46, Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com> wrote:
>
> From: Lo-Hsiang Lo <double.lo@cypress.com>
>
> There is a system warning message, warn_slowpath-fmt, during suspend
> while using supplicant join AP and enable wowl feature by IW command.
> It's cuased by brcmf_pno_remove_request path can't find the reqid.
> This fix will not go to remove pno request function if there is no
> pno scan.
Typo in the commit message `cuased`
>
> Signed-off-by: Lo-Hsiang Lo <double.lo@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> index ffa243e2e2d0..55974a43796a 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> @@ -496,6 +496,11 @@ int brcmf_pno_stop_sched_scan(struct brcmf_if *ifp, u64 reqid)
> brcmf_dbg(TRACE, "reqid=%llu\n", reqid);
>
> pi = ifp_to_pno(ifp);
> +
> + /* No PNO reqeuset */
Typo. `reqeuset`
> + if (!pi->n_reqs)
> + return 0;
> +
> err = brcmf_pno_remove_request(pi, reqid);
> if (err)
> return err;
> --
> 2.1.0
>
next prev parent reply other threads:[~2019-01-03 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 7:46 [PATCH 0/2] brcmfmac: wake on wireless LAN changes Chi-Hsien Lin
2019-01-03 7:46 ` [PATCH 1/2] brcmfmac: fix system warning message during wowl suspend Chi-Hsien Lin
2019-01-03 9:56 ` James Hughes [this message]
2019-01-07 9:16 ` Chi-Hsien Lin
2019-01-04 11:37 ` Arend Van Spriel
2019-01-03 7:46 ` [PATCH 2/2] brcmfmac: support wake on ping packet Chi-Hsien Lin
2019-01-04 12:17 ` Arend Van Spriel
2019-01-07 8:46 ` Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE_XsM+mdHkwMF3PEimVJBpLd=oMmuvK1uDdA7y8uJT8hYNfbA@mail.gmail.com' \
--to=james.hughes@raspberrypi.org \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=Double.Lo@cypress.com \
--cc=Wright.Feng@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).