From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-io0-f177.google.com ([209.85.223.177]:36010 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549AbcBAKXW (ORCPT ); Mon, 1 Feb 2016 05:23:22 -0500 MIME-Version: 1.0 In-Reply-To: <20160201093346.GA10500@sudip-pc> References: <1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com> <20160201042548.GA4072@sudip-pc> <878u34u6d6.fsf@purkki.adurom.net> <20160201093346.GA10500@sudip-pc> From: Julian Calaby Date: Mon, 1 Feb 2016 21:23:02 +1100 Message-ID: (sfid-20160201_112407_986126_918541FD) Subject: Re: [PATCH] mac80211: fix memory leak To: Sudip Mukherjee Cc: Kalle Valo , Johannes Berg , "David S. Miller" , "linux-kernel@vger.kernel.org" , linux-wireless , netdev Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Sudip, On Mon, Feb 1, 2016 at 8:33 PM, Sudip Mukherjee wrote: > On Mon, Feb 01, 2016 at 11:28:37AM +0200, Kalle Valo wrote: >> Sudip Mukherjee writes: >> >> > On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >> >> Hi Sudip, >> >> >> >> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >> >> wrote: >> >> > On error we jumped to the error label and returned the error code but we >> >> > missed releasing sinfo. >> >> > >> >> > Signed-off-by: Sudip Mukherjee >> >> >> >> Should the From: and Signed-off-by: email addresses be the same? >> > >> > I think 2 years back I had a long discussion with Greg about this and >> > since then I al submitting patches like this. A small summayg of the >> > problem from that discussion: >> > >> > "we have strict DMARC check for the corporate mail server. DMARC = >> > domain based message authentication. >> > So the mail i sent reached all the list subscriber from a different >> > server than our designated server, and as a result it is marked as spam >> > in many places and I have already received a few complaints regarding >> > that." >> >> You can add a separate "From:" line to the beginning of the commit log >> and git will use it then commiting the patch. I didn't find any >> documention but it's easy to do and should solve this. > > Documentation is not needed. :) > I have done that couple of time. > I will resend this patch with the extra From: line. Don't forget to include the Fixes: tag. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/