linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julian Calaby <julian.calaby@gmail.com>
To: Geoff Lansberry <geoff@kuvee.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	mgreer@animalcreek.com, justin@kuvee.com
Subject: Re: [PATCH 3/4] NFC: trf7970a: add device tree option for 27MHz clock
Date: Tue, 19 Apr 2016 10:11:46 +1000	[thread overview]
Message-ID: <CAGRGNgUQ995jj_hGY=wR4LmND=h1kCU1tpQ+p8YRN2kqmjDgOg@mail.gmail.com> (raw)
In-Reply-To: <1461008921-15100-4-git-send-email-geoff@kuvee.com>

Hi Geoff,

On Tue, Apr 19, 2016 at 5:48 AM, Geoff Lansberry <geoff@kuvee.com> wrote:
> Signed-off-by: Geoff Lansberry <geoff@kuvee.com>

You should add the description you had in your cover letter to the patches also.

> ---
>  .../devicetree/bindings/net/nfc/trf7970a.txt       |  2 ++
>  drivers/nfc/trf7970a.c                             | 28 +++++++++++++---------
>  2 files changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> index 09c5056..bf25f39 100644
> --- a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> +++ b/Documentation/devicetree/bindings/net/nfc/trf7970a.txt
> @@ -22,6 +22,7 @@ Optional SoC Specific Properties:
>  - t5t-rmb-extra-byte-quirk: Specify that the trf7970a has the erratum
>    where an extra byte is returned by Read Multiple Block commands issued
>    to Type 5 tags.
> +- crystal_27mhz: Set to specify that the input frequency to the trf7970a is 27.12MHz

Does the trf7970a only operate at the default or 27.12MHz, or can it
operate at any frequency? If it's the latter, would it make sense to
specify this using the clock framework and some fixed-factor clock?

Thanks,

Julian Calaby


>  Example (for ARM-based BeagleBone with TRF7970A on SPI1):
>
> @@ -45,6 +46,7 @@ Example (for ARM-based BeagleBone with TRF7970A on SPI1):
>                 irq-status-read-quirk;
>                 en2-rf-quirk;
>                 t5t-rmb-extra-byte-quirk;
> +               crystal_27mhz;
>                 status = "okay";
>         };
>  };
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 447b6c9..74210f9 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -1072,12 +1072,11 @@ static int trf7970a_init(struct trf7970a *trf)
>
>         trf->chip_status_ctrl &= ~TRF7970A_CHIP_STATUS_RF_ON;
>
> -       ret = trf7970a_write(trf, TRF7970A_MODULATOR_SYS_CLK_CTRL, 0);
> +       ret = trf7970a_write(trf, TRF7970A_MODULATOR_SYS_CLK_CTRL,
> +                       trf->modulator_sys_clk_ctrl);
>         if (ret)
>                 goto err_out;
>
> -       trf->modulator_sys_clk_ctrl = 0;
> -
>         ret = trf7970a_write(trf, TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS,
>                         TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS_WLH_96 |
>                         TRF7970A_ADJUTABLE_FIFO_IRQ_LEVELS_WLL_32);
> @@ -1194,30 +1193,32 @@ static int trf7970a_in_config_rf_tech(struct trf7970a *trf, int tech)
>
>         dev_dbg(trf->dev, "rf technology: %d\n", tech);
>
> +       trf->modulator_sys_clk_ctrl = (trf->modulator_sys_clk_ctrl&0xF8);
> +
>         switch (tech) {
>         case NFC_DIGITAL_RF_TECH_106A:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_14443A_106;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK;
>                 trf->guard_time = TRF7970A_GUARD_TIME_NFCA;
>                 break;
>         case NFC_DIGITAL_RF_TECH_106B:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_14443B_106;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10;
>                 trf->guard_time = TRF7970A_GUARD_TIME_NFCB;
>                 break;
>         case NFC_DIGITAL_RF_TECH_212F:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_FELICA_212;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10;
>                 trf->guard_time = TRF7970A_GUARD_TIME_NFCF;
>                 break;
>         case NFC_DIGITAL_RF_TECH_424F:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_FELICA_424;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10;
>                 trf->guard_time = TRF7970A_GUARD_TIME_NFCF;
>                 break;
>         case NFC_DIGITAL_RF_TECH_ISO15693:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_15693_SGL_1OF4_2648;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK;
>                 trf->guard_time = TRF7970A_GUARD_TIME_15693;
>                 break;
>         default:
> @@ -1582,22 +1583,24 @@ static int trf7970a_tg_config_rf_tech(struct trf7970a *trf, int tech)
>
>         dev_dbg(trf->dev, "rf technology: %d\n", tech);
>
> +       trf->modulator_sys_clk_ctrl = (trf->modulator_sys_clk_ctrl&0xF8);
> +
>         switch (tech) {
>         case NFC_DIGITAL_RF_TECH_106A:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE |
>                         TRF7970A_ISO_CTRL_NFC_CE |
>                         TRF7970A_ISO_CTRL_NFC_CE_14443A;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_OOK;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_OOK;
>                 break;
>         case NFC_DIGITAL_RF_TECH_212F:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE |
>                         TRF7970A_ISO_CTRL_NFC_NFCF_212;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10;
>                 break;
>         case NFC_DIGITAL_RF_TECH_424F:
>                 trf->iso_ctrl_tech = TRF7970A_ISO_CTRL_NFC_NFC_CE_MODE |
>                         TRF7970A_ISO_CTRL_NFC_NFCF_424;
> -               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_DEPTH_ASK10;
> +               trf->modulator_sys_clk_ctrl |= TRF7970A_MODULATOR_DEPTH_ASK10;
>                 break;
>         default:
>                 dev_dbg(trf->dev, "Unsupported rf technology: %d\n", tech);
> @@ -2072,6 +2075,9 @@ static int trf7970a_probe(struct spi_device *spi)
>                 return ret;
>         }
>
> +       if (of_property_read_bool(np, "crystal_27MHz"))
> +               trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
> +
>         if (of_property_read_bool(np, "en2-rf-quirk"))
>                 trf->quirks |= TRF7970A_QUIRK_EN2_MUST_STAY_LOW;
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

  reply	other threads:[~2016-04-19  0:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 19:48 [Patch] NFC: trf7970a: Geoff Lansberry
2016-04-18 19:48 ` [PATCH 1/4] NFC: trf7970a: Add support for gpio as SS Geoff Lansberry
2016-04-19  0:07   ` Julian Calaby
     [not found]     ` <CAO7Z3WJofeT4agChaZ-NQ5TwrMygdGRhG7myJkNuEb9i_g-Y=A@mail.gmail.com>
2016-04-20  1:24       ` Geoffrey Lansberry
2016-04-18 19:48 ` [PATCH 2/4] NFC: trf7970a: add TI recommended write of zero to Register 0x18 Geoff Lansberry
2016-04-18 19:48 ` [PATCH 3/4] NFC: trf7970a: add device tree option for 27MHz clock Geoff Lansberry
2016-04-19  0:11   ` Julian Calaby [this message]
2016-04-18 19:48 ` [PATCH 4/4] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry
2016-04-19  0:12   ` Julian Calaby
2016-04-22  0:01 ` [Patch] NFC: trf7970a: Mark Greer
2016-12-13 22:05   ` Mark Greer
     [not found]     ` <CAO7Z3WJwf80mCqubSYTeK=BHN9sd=mzmL9th4Su-E25de6TmAg@mail.gmail.com>
2016-12-14 15:57       ` Mark Greer
2016-12-14 16:17         ` Geoff Lansberry
2016-12-14 17:10           ` Mark Greer
2016-12-14 18:35             ` Geoff Lansberry
2016-12-14 22:31               ` Mark Greer
2016-12-16  4:52                 ` Mark Greer
2016-12-16 20:35                   ` Mark Greer
2016-12-17 21:19                     ` Geoff Lansberry
2016-12-19  3:07                       ` Mark Greer
2017-02-08 22:53                         ` Mark Greer
2017-02-08 22:56                           ` Mark Greer
2017-02-09 15:54                             ` Geoff Lansberry
2017-02-09 21:27                               ` Mark Greer
2017-02-10  0:41                                 ` Geoff Lansberry
2017-02-10  4:20                                   ` Mark Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGRGNgUQ995jj_hGY=wR4LmND=h1kCU1tpQ+p8YRN2kqmjDgOg@mail.gmail.com' \
    --to=julian.calaby@gmail.com \
    --cc=aloisio.almeida@openbossa.org \
    --cc=geoff@kuvee.com \
    --cc=justin@kuvee.com \
    --cc=lauro.venancio@openbossa.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).