From: Julian Calaby <julian.calaby@gmail.com>
To: merez@codeaurora.org
Cc: Kalle Valo <kvalo@codeaurora.org>,
Maya Erez <qca_merez@qca.qualcomm.com>,
Lazar Alexei <QCA_ailizaro@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
wil6210@qca.qualcomm.com, linux-wireless-owner@vger.kernel.org
Subject: Re: [v2,6/9] wil6210: add support for headroom configuration
Date: Wed, 17 Jan 2018 21:11:38 +1100 [thread overview]
Message-ID: <CAGRGNgUmtZcW=xewDPCathwCUMXjqXk_qTPcOjb9+VCOm=nskg@mail.gmail.com> (raw)
In-Reply-To: <1384d3ee94eb48f29e85161d9a8fa136@codeaurora.org>
Hi Maya,
On Tue, Jan 16, 2018 at 12:18 AM, <merez@codeaurora.org> wrote:
> On 2018-01-09 10:07, Kalle Valo wrote:
>>
>> Maya Erez <qca_merez@qca.qualcomm.com> wrote:
>>
>>> Add module parameter for configuring the headroom size
>>> in the skb allocation.
>>>
>>> Signed-off-by: Lazar Alexei <qca_ailizaro@qca.qualcomm.com>
>>> Signed-off-by: Maya Erez <qca_merez@qca.qualcomm.com>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>>
>> Why?
>
>
> Some platforms have specific requirements on packet alignment.
> I will upload an update of the commit text in the next set of 11ad patches.
Is this something the platform can tell you or something you can store
in an array by platform name? (and use the maximum size if we don't
know)
Alternatively, would it waste too much RAM to just set this to the
maximum size and have done?
I feel that allowing the user to set it will be problematic.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
next prev parent reply other threads:[~2018-01-17 10:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 16:53 [PATCH v2 0/9] wil6210 patches Maya Erez
2017-12-14 16:53 ` [PATCH v2 1/9] wil6210: support Scheduled scan Maya Erez
2018-01-09 8:04 ` [v2,1/9] " Kalle Valo
2017-12-14 16:53 ` [PATCH v2 2/9] wil6210: support 40bit DMA addresses Maya Erez
2017-12-14 16:53 ` [PATCH v2 3/9] wil6210: add platform capabilities bitmap Maya Erez
2017-12-14 16:53 ` [PATCH v2 4/9] wil6210: set platform features based on FW capabilities Maya Erez
2017-12-14 16:53 ` [PATCH v2 5/9] wil6210: prevent parallel suspend and dump collection Maya Erez
2017-12-14 16:53 ` [PATCH v2 6/9] wil6210: add support for headroom configuration Maya Erez
2018-01-09 8:07 ` [v2,6/9] " Kalle Valo
2018-01-15 13:18 ` merez
2018-01-17 10:11 ` Julian Calaby [this message]
2018-01-17 11:47 ` Kalle Valo
2017-12-14 16:53 ` [PATCH v2 7/9] wil6210: configurable broadcast TX MCS Maya Erez
2018-01-09 8:09 ` [v2,7/9] " Kalle Valo
2017-12-14 16:53 ` [PATCH v2 8/9] wil6210: remove leftover "FIXME"s Maya Erez
2017-12-14 16:53 ` [PATCH v2 9/9] wil6210: remove reference to preset_chandef Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRGNgUmtZcW=xewDPCathwCUMXjqXk_qTPcOjb9+VCOm=nskg@mail.gmail.com' \
--to=julian.calaby@gmail.com \
--cc=QCA_ailizaro@qca.qualcomm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).