linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFC: pn533: mark expected switch fall-throughs
Date: Tue, 9 Apr 2019 09:29:43 -0700	[thread overview]
Message-ID: <CAGXu5jLaZ3czP9YDJ9R+3UeBxuULubBPcnFNdh+qT_S9D5eZZg@mail.gmail.com> (raw)
In-Reply-To: <20190213185741.GA5047@embeddedor>

On Wed, Feb 13, 2019 at 10:57 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/nfc/pn533/pn533.c: In function ‘pn533_transceive’:
> drivers/nfc/pn533/pn533.c:2142:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
>       ^
> drivers/nfc/pn533/pn533.c:2150:2: note: here
>   default:
>   ^~~~~~~
> drivers/nfc/pn533/pn533.c: In function ‘pn533_wq_mi_recv’:
> drivers/nfc/pn533/pn533.c:2267:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (dev->tgt_active_prot == NFC_PROTO_FELICA) {
>       ^
> drivers/nfc/pn533/pn533.c:2276:2: note: here
>   default:
>   ^~~~~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Addresses-Coverity-ID: 1230487 ("Missing break in switch")
> Addresses-Coverity-ID: 1230488 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

-- 
Kees Cook

  parent reply	other threads:[~2019-04-09 16:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 18:57 [PATCH] NFC: pn533: mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 19:21 ` Gustavo A. R. Silva
2019-04-09 16:29 ` Kees Cook [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-05  7:20 Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5jLaZ3czP9YDJ9R+3UeBxuULubBPcnFNdh+qT_S9D5eZZg@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).