From: Linus Torvalds <torvalds@linux-foundation.org>
To: Kalle Valo <kvalo@kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>
Cc: "Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Linux Wireless" <linux-wireless@vger.kernel.org>,
pagadala.yesu.anjaneyulu@intel.com,
"Linux Regressions" <regressions@lists.linux.dev>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Niklāvs Koļesņikovs" <pinkflames.linux@gmail.com>,
"Damian Tometzki" <damian@riscv-rocks.de>
Subject: Re: [PATCH v4] wifi: iwlwifi: fix system commands group ordering
Date: Sun, 12 Nov 2023 11:39:07 -0800 [thread overview]
Message-ID: <CAHk-=wgyG-8ehCc4C4V-b-8rBtfyd9ApDeQSx-5BKRaHywhVpw@mail.gmail.com> (raw)
In-Reply-To: <875y26ajks.fsf@kernel.org>
On Sun, 12 Nov 2023 at 10:54, Kalle Valo <kvalo@kernel.org> wrote:
>
> Linus, I suspect it will take a while before we make a new wireless pull
> request (there's currently just one commit in the wireless tree). So if
> you want to take this directly to your tree please go ahead, otherwise
> you get it via the normal route in a week or two. Just let us know what
> you prefer.
>
> Acked-by: Kalle Valo <kvalo@kernel.org>
Ok, I just tested it in my private tree, and it fixes the WARN_ON() as
expected, so I'll apply it for real.
However, now that I don't have that big warning in there, I do note
another iwlwifi issue that is new to this meger window:
debugfs: Directory 'iwlmvm' with parent 'netdev:wlo2' already present!
iwlwifi 0000:45:00.0: Failed to create debugfs directory under netdev:wlo2
debugfs: Directory 'iwlmvm' with parent 'netdev:wlo2' already present!
iwlwifi 0000:45:00.0: Failed to create debugfs directory under netdev:wlo2
and looking at my system logs, this is new.
It looks like it is probably due to
c36235acb34f ("wifi: iwlwifi: mvm: rework debugfs handling")
e9dd25550770 ("wifi: iwlwifi: mvm: add a per-link debugfs")
but that's just from looking at the patches (ie no bisection or any
real effort).
This is after the system has come up, so I assume it's when
networkmanager or whatever actually is setting that wireless thing up.
Again: I actually don't *use* the WiFi on this machine - but from a
quick check it does seem to work. So this is just an annoyance and a
sign that somebody didn't do all the details right (possibly triggered
by odd user land behavior, of course, but still...)
Linus
next prev parent reply other threads:[~2023-11-12 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 9:59 [PATCH] wifi: iwlwifi: fix system commands group ordering Emmanuel Grumbach
2023-11-12 10:05 ` [PATCH v2] " Emmanuel Grumbach
2023-11-12 10:09 ` [PATCH v3] " Emmanuel Grumbach
2023-11-12 14:08 ` Bagas Sanjaya
2023-11-12 14:36 ` [PATCH v4] " Emmanuel Grumbach
2023-11-12 18:54 ` Kalle Valo
2023-11-12 19:39 ` Linus Torvalds [this message]
2023-11-12 19:53 ` Emmanuel Grumbach
2023-11-12 20:01 ` Emmanuel Grumbach
2023-11-13 16:10 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgyG-8ehCc4C4V-b-8rBtfyd9ApDeQSx-5BKRaHywhVpw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=damian@riscv-rocks.de \
--cc=emmanuel.grumbach@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=pinkflames.linux@gmail.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).