Re: [PATCH] brcmfmac: pcie: fix oops on failure to resume and reprobe

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Chi-hsien Lin <chi-hsien.lin@infineon.com>,
	Wright Feng <wright.feng@infineon.com>,
	Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"SHA-cyfmac-dev-list@infineon.com"
	<SHA-cyfmac-dev-list@infineon.com>,
	"brcm80211-dev-list.pdl@broadcom.com" 
	<brcm80211-dev-list.pdl@broadcom.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] brcmfmac: pcie: fix oops on failure to resume and reprobe
Date: Tue, 17 Aug 2021 14:54:16 +0300	[thread overview]
Message-ID: <CAHp75VfahF=_CmS7kw5PbKs46+hXFweweq=sjwd83hccRsrH9g@mail.gmail.com> (raw)
In-Reply-To: <3a9a3789-5a13-7e72-b909-8f0826b8ab86@pengutronix.de>

On Tue, Aug 17, 2021 at 2:11 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> On 17.08.21 13:02, Andy Shevchenko wrote:
> > On Tuesday, August 17, 2021, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:

...

> >>         err = brcmf_pcie_probe(pdev, NULL);
> >>         if (err)
> >> -               brcmf_err(bus, "probe after resume failed, err=%d\n", err);
> >> +               __brcmf_err(NULL, __func__, "probe after resume failed,
> >> err=%d\n",
> >
> >
> > This is weird looking line now. Why can’t you simply use dev_err() /
> > netdev_err()?
>
> That's what brcmf_err normally expands to, but in this file the macro
> is overridden to add the extra first argument.

So, then the problem is in macro here. You need another portion of
macro(s) that will use the dev pointer directly. When you have a valid
device, use it. And here it seems the case.

> The brcmf_ logging function write to brcmf trace buffers. This is not
> done with netdev_err/dev_err (and replacing the existing logging
> is out of scope for a regression fix anyway).

I see.

-- 
With Best Regards,
Andy Shevchenko