From: Haggai Eran <haggai.eran@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Arend van Spriel <aspriel@gmail.com>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: kernel page fault in r8712u
Date: Mon, 18 May 2015 20:38:20 +0300 [thread overview]
Message-ID: <CAJ=9CzbrwmG5x6i9wOH0g9hwNq27J_maVe7kS8Nco9y4BJEOpg@mail.gmail.com> (raw)
In-Reply-To: <555A05DC.8080704@lwfinger.net>
On 18 May 2015 at 18:31, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 05/17/2015 02:22 PM, Haggai Eran wrote:
>>
>> I added some debugging prints, trying to see more details about the
>> packet that fails the r8712_validate_recv_frame. I noticed I'm getting
>> many packets where recv_decache returns _FAIL. However, the last two
>> packets before the crash fail for different reasons. The first has the
>> ver field set to 3 (instead of zero). The second (the one that get's
>> freed and cause the crash apparently) has an unknown type (12). If I'm
>> not mistaken, 12 = WIFI_CTRL_TYPE | WIFI_DATA_TYPE. Is that possible?
>>
>> It could be that the packet headers are garbled though.
>
>
> I think the headers are garbled. Did you log the address of the skb at
> precvframe->u.hdr.pkt in r8712_free_recvframe() or orig_prframe->u.hdr.pct
> in recv_func().
I haven't. I'll print that.
>
> I am still dubious of the cast "prframe = (union recv_frame *)pcontext;" in
> recv_func().
Why? As far as I can see, recv_func is called only at one place
(r8712_recv_entry), where it is passed a union recv_frame * as the
pcontext parameter.
Haggai
next prev parent reply other threads:[~2015-05-18 17:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 12:17 kernel page fault in r8712u Haggai Eran
2015-05-16 14:57 ` Larry Finger
2015-05-16 17:16 ` Haggai Eran
2015-05-16 17:41 ` Larry Finger
2015-05-16 17:54 ` Larry Finger
2015-05-17 4:25 ` Haggai Eran
2015-05-17 10:29 ` Arend van Spriel
2015-05-17 17:20 ` Haggai Eran
2015-05-17 19:22 ` Haggai Eran
2015-05-18 15:31 ` Larry Finger
2015-05-18 17:38 ` Haggai Eran [this message]
2015-05-18 18:38 ` Haggai Eran
2015-05-19 4:52 ` Larry Finger
2015-05-19 5:00 ` Haggai Eran
2015-05-19 5:16 ` Haggai Eran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=9CzbrwmG5x6i9wOH0g9hwNq27J_maVe7kS8Nco9y4BJEOpg@mail.gmail.com' \
--to=haggai.eran@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=aspriel@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).