From: Tom Psyborg <pozega.tomislav@gmail.com>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
Ben Greear <greearb@candelatech.com>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>
Subject: Re: [PATCH] ath10k: Fix ASPM L1 state on QCA988X
Date: Wed, 25 Sep 2019 12:35:05 +0200 [thread overview]
Message-ID: <CAKR_QV+TDi5DQ5Vsc-nactAryzAExe470VNJ+tj+vUa37rs_Xg@mail.gmail.com> (raw)
In-Reply-To: <a87917de-d60c-b746-742a-ade37ffe9c4c@candelatech.com>
Hi
Some more info: the actual regression was introduced with the commit:
ath10k: enable ASPM - reverting this change only is enough to have
card operating as expected.
Still, this patch would apply, but in slightly different manner.
On OpenWrt router, masked value would always read 0x27 with two cards
tested QCA9862 and QCA9880 v1.
But on HP laptop, QCA9862 masked value reading was 0x0f, and writing
0x27 to this register still seems fine, as long as the faulty ASPM
change is kept reverted.
I did also notice about 10°C temperature drop in ath10k_hwmon and no
more crashes when resuming from sleep, but that might be related to
the fact these tests were now done with backports-5.1 instead of the
in-tree 4.9 driver.
next prev parent reply other threads:[~2019-09-25 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:59 [PATCH] ath10k: Fix ASPM L1 state on QCA988X Tomislav Požega
2019-03-19 20:45 ` Peter Oh
2019-03-19 21:02 ` Tom Psyborg
2019-03-20 15:12 ` Ben Greear
2019-03-20 15:48 ` Tom Psyborg
2019-03-20 15:59 ` Ben Greear
2019-09-25 10:35 ` Tom Psyborg [this message]
2019-10-03 13:33 ` Kalle Valo
2019-10-03 14:01 ` Tom Psyborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKR_QV+TDi5DQ5Vsc-nactAryzAExe470VNJ+tj+vUa37rs_Xg@mail.gmail.com \
--to=pozega.tomislav@gmail.com \
--cc=c_manoha@qca.qualcomm.com \
--cc=greearb@candelatech.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).