From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB9DC41514 for ; Fri, 16 Aug 2019 08:31:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A769A206C2 for ; Fri, 16 Aug 2019 08:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oCj+GOx8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726893AbfHPIbd (ORCPT ); Fri, 16 Aug 2019 04:31:33 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46718 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfHPIbd (ORCPT ); Fri, 16 Aug 2019 04:31:33 -0400 Received: by mail-wr1-f68.google.com with SMTP id z1so732024wru.13 for ; Fri, 16 Aug 2019 01:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nMteWjiol09LnNTGAtg+qqwxoUC+aePsLIm1kIpTrJs=; b=oCj+GOx8zj3DZDR8aTDgqrL6lshNRYHcEJ9xc7u/k5AAXmEozG5CiyjIcN62uoR4yk /dZXF2qmsL6jlDXs1GlkR2A/kSPm/FFMDejUbnIKqNjQtHvOcl4zAg6VDFE80jvid6MD 52rJCbC9f15qQ3tWLYI9mE+Qjr2VSBI/Xc+5cXxFil0vTyG3GnDha7zPP8OJddjUr/Hq kon3JPJo1IcTbdJL2KaVY8vLnRPATMCLI5ZJACiqczFx0h7wXsZNpPh56pMC+YTAO9cW 6XPg2vjaqtITAY9hZVyE6bhzL/BLKppzKSylT9ZNyy0Rn17zbVd0dOqMqj5AMFhpoO7L oyPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nMteWjiol09LnNTGAtg+qqwxoUC+aePsLIm1kIpTrJs=; b=bAK9z8wKXwe99VXuhIq9Pw7lKnDSqPmsAFIaYf7SPMfYmCa9jf9smVsVO3Yf1KnvX9 UkTVV0/mbDNtS+tmrtegHm26aBH/19vDBmkRPGIi6kmM31eHuQFk+2pO2CWjdjUOIMYZ V6xnpfL1P50+i3Ce4BIrVkFQNHn0mdqw/EqfFY+O6zUupMFo4a+mhp7kWgXLxYaA6aBR fAcVtpN4FnSkcIuY566QVymFxoKbATQYqaHHZ7bTmaf8DaaEltCaM/TEksVgbMcZHfiC T/qjZdIv+4SJzC+oMrlyQYLKHsLmY3sd5zeTptnSVXxo/tkbhsPXhV4TLW41u369067z ylXw== X-Gm-Message-State: APjAAAXC8pN5BiAVRBGSAUR7UeV2XQ+qMjMwGUYCpjZNeVMp1bi6jOn9 XD45qqKuybDzrJ2GSRYpsoK6A3Pc9gs6TD+C2HDctQ== X-Google-Smtp-Source: APXvYqwh5XDkO7F2xERL7f+E+ehgrXGdbgDaiyV9najpnyy1GfPAMnxMomE45gSsbegm0OpSlpcxM0Q0s5kDUvwvH7k= X-Received: by 2002:adf:e8c2:: with SMTP id k2mr9106596wrn.198.1565944291339; Fri, 16 Aug 2019 01:31:31 -0700 (PDT) MIME-Version: 1.0 References: <20190816065936.12214-1-contact@christina-quast.de> In-Reply-To: <20190816065936.12214-1-contact@christina-quast.de> From: Ard Biesheuvel Date: Fri, 16 Aug 2019 11:31:23 +0300 Message-ID: Subject: Re: [PATCH 0/2] Use ccm(aes) aead transform in staging drivers To: Christina Quast Cc: Greg Kroah-Hartman , Payal Kshirsagar , Eric Biggers , Herbert Xu , "open list:ANDROID DRIVERS" , Linux Kernel Mailing List , Anushka Shukla , Bartlomiej Zolnierkiewicz , Zach Turner , "" , Johannes Berg , "David S. Miller" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 16 Aug 2019 at 10:00, Christina Quast wrote: > > Use ccm(aes) aead transform instead of invoking the AES block cipher > block by block. > Thanks! This eliminates another two users of the bare cipher API, which is not the right abstraction for drivers to use. Reviewed-by: Ard Biesheuvel I don't have the hardware, so I can't test this. > Christina Quast (2): > staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API > ccm(aes) > staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes) > > drivers/staging/rtl8192e/Kconfig | 1 + > drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 187 ++++++++---------- > drivers/staging/rtl8192u/Kconfig | 2 + > .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 187 ++++++++---------- > 4 files changed, 159 insertions(+), 218 deletions(-) > > -- > 2.20.1 >