From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1041EC742A2 for ; Fri, 12 Jul 2019 00:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCB272084B for ; Fri, 12 Jul 2019 00:19:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H8jwe3rC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730458AbfGLATG (ORCPT ); Thu, 11 Jul 2019 20:19:06 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36658 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbfGLATG (ORCPT ); Thu, 11 Jul 2019 20:19:06 -0400 Received: by mail-pf1-f196.google.com with SMTP id r7so3499313pfl.3 for ; Thu, 11 Jul 2019 17:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cXwPjnGAmuSK2ZaU+Ltpqy4ycTb2N7DG1+z1aocDv54=; b=H8jwe3rChH4G7iCj19aG+jdTznh7B97b9IBA1NFnsgbjB1uousOK0oJNLWfDlTXmK4 zufv/ozFwoIPysjElmQ+t7Zg/hhXPAHCnhEDd0dBt8Gu7JYSKV35byBYpmzHzICcRhIw d6WUTeL5mu3lCkjv0XPOuvqx+VP/f61fQhPzrIoX+wmbrcbPMxjBYMeoOWFP+DBo26or spJ7MHeVaPilLfnoqqASjaXWKqJ+0XEq5Ong80tp7CMEGVVSadV16s/Ng7p0tLLORU7D qAXfW8mGQtfQcDjhIz7eSMepf70vkowGJn8eHxEeBRGLbbL9+4wLVZMnKqQHP5SjG4Gh Jsxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cXwPjnGAmuSK2ZaU+Ltpqy4ycTb2N7DG1+z1aocDv54=; b=l5lER9wyUG/XaxVKj0ReZopHXQlNx9kBR6dNY4vzUgdEdgTi4POTi65jwRMhXU5+45 fvezBVcPinLhOUpt/Iugz8FWTo3ZhXVr8E10Ic8i1GARlfRjasbO0wDBsndfQmo55+nM +SOPbQ6Wznfg7Li5QLOhBSAb3xwtSTAMvfwUalOlUEq4C3Rpvm81rPhtQLz8EeKSxbX+ geeUNKj7pN++htcXjo26YSQP4E+TNDpfZweM5iA3AMM8D53wC8ABrlfdNkpyv52Sx+Cs wnZVyhoLsG78MBuE/aUPef5IDlApQ4rg57PgIVYJE6q7IbkQpWHp53utw1RVdUelIYWz 4Hnw== X-Gm-Message-State: APjAAAV4/OZTUT/gxcxySOvsiY60doBxpwIYtSx1BsnzKNFNciLPd1HD NIU38EYVRjutWrl5EnnWX84atXGnGy/iSHqjSkUdOA== X-Google-Smtp-Source: APXvYqz8a97UOm7FtJ1ymacgN41+7iKD+V77S1AaSr9ry+cK2pVeO54pyfOkaOO8sRGs6RyjYFwX1TFVH5CYtrb+7Z4= X-Received: by 2002:a17:90a:2488:: with SMTP id i8mr7784463pje.123.1562890745251; Thu, 11 Jul 2019 17:19:05 -0700 (PDT) MIME-Version: 1.0 References: <20190712001708.170259-1-ndesaulniers@google.com> In-Reply-To: <20190712001708.170259-1-ndesaulniers@google.com> From: Nick Desaulniers Date: Thu, 11 Jul 2019 17:18:54 -0700 Message-ID: Subject: Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static To: Kalle Valo Cc: Arnd Bergmann , Nathan Chancellor , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Shahar S Matityahu , Sara Sharon , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, LKML , clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jul 11, 2019 at 5:17 PM Nick Desaulniers wrote: > > Commit r353569 in prerelease Clang-9 is producing a linkage failure: > > ld: drivers/net/wireless/intel/iwlwifi/fw/dbg.o: > in function `_iwl_fw_dbg_apply_point': > dbg.c:(.text+0x827a): undefined reference to `__compiletime_assert_2387' > > when the following configs are enabled: > - CONFIG_IWLWIFI > - CONFIG_IWLMVM > - CONFIG_KASAN > > Work around the issue for now by marking the debug strings as `static`, > which they probably should be any ways. > > Link: https://bugs.llvm.org/show_bug.cgi?id=42580 > Link: https://github.com/ClangBuiltLinux/linux/issues/580 > Reported-by: Arnd Bergmann > Reported-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Sorry, I forgot a very important: Suggested-by: Eli Friedman > --- > drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > index e411ac98290d..f8c90ea4e9b4 100644 > --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c > @@ -2438,7 +2438,7 @@ static void iwl_fw_dbg_info_apply(struct iwl_fw_runtime *fwrt, > { > u32 img_name_len = le32_to_cpu(dbg_info->img_name_len); > u32 dbg_cfg_name_len = le32_to_cpu(dbg_info->dbg_cfg_name_len); > - const char err_str[] = > + static const char err_str[] = > "WRT: ext=%d. Invalid %s name length %d, expected %d\n"; > > if (img_name_len != IWL_FW_INI_MAX_IMG_NAME_LEN) { > @@ -2775,7 +2775,7 @@ static void _iwl_fw_dbg_apply_point(struct iwl_fw_runtime *fwrt, > struct iwl_ucode_tlv *tlv = iter; > void *ini_tlv = (void *)tlv->data; > u32 type = le32_to_cpu(tlv->type); > - const char invalid_ap_str[] = > + static const char invalid_ap_str[] = > "WRT: ext=%d. Invalid apply point %d for %s\n"; > > switch (type) { > -- > 2.22.0.410.gd8fdbe21b5-goog > -- Thanks, ~Nick Desaulniers