From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2D4C433F5 for ; Wed, 10 Nov 2021 21:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39A0D61207 for ; Wed, 10 Nov 2021 21:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233444AbhKJVlO (ORCPT ); Wed, 10 Nov 2021 16:41:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233321AbhKJVlO (ORCPT ); Wed, 10 Nov 2021 16:41:14 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA6F9C061767 for ; Wed, 10 Nov 2021 13:38:25 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id u11so9301888lfs.1 for ; Wed, 10 Nov 2021 13:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D1z6yFw1+0sjIG7f/nWzQHi2azAv8rrhzZz6SpWHNuM=; b=WEIjO9suAw0S5n0/8xePw/9zyOCQ82BMKNODVfHoR78GTG3zeg6GkhFPCLJIsFCjvz bJVm0yam2RSFMl3esknEdAS9ODHTqOy6amhxC12wyjiqlgdEelF/QpVTDjnrApktgtae ZNBHIp4VnoNFbkYwJlv8VqK7o/V4J+shWCYxlKqY3dDyttmXnbPccPYE+njowYXo5fJX qhDwePaO54X/c5iyD0ah9kw0f52od9wnZA3OOYLBr/7pH/AEmkc5xs5fotAaSDnUS+jK P9nXANp5U4MtyprHHDl48a27zc++RXkCphZMYxvelIGof9UepJFEp4Ir631Sdg4LHk4A hN1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D1z6yFw1+0sjIG7f/nWzQHi2azAv8rrhzZz6SpWHNuM=; b=VwXklvV1jkblIi34wg5TMsQbzjgupWllGJ6DSP3oTr5UX+GAOZ3H4jQbwP9eBRUY+R V+EYBo397i2RM+x4flol/ZaaoIrOUn6JFgjdy5Bi941KoWmE5NW04+F/JbNaDtBwc1CJ hHWh7FFQaqgvBdE4evox0uIOTGO4joaK7/RTReyN6HrP+L46kHa2iHvYCTee34i60Wcy uVuRW1V21yEPajJbWG5bUkoZAgzHgt+nA1Dl7DH5WNrEGMA7Neo85V55R30Nf2zjvvzp S3mR5cZ/wTia9FqCxtq5ienVAOW3g44HH3138SAliF2CJbMLUzBOY1zSY1NEYEeenm/l NzeA== X-Gm-Message-State: AOAM533OOOOazkIFt2/IjWj6DWY82xHoC2gjvOgUe0wtVbaCvd9nQKH/ XEiolLGXFqaNi/n2v0FV7sLEMlWgiq2+pSGH+i7t1Q== X-Google-Smtp-Source: ABdhPJzjaFy5q9lDBd1wo9aZvGBOM/b8VEotHF5YZ79B0EbTM7S5RL5M93fguRMPKxqbWX/iwxlaCKZr5lO5Q3V9YmA= X-Received: by 2002:a05:6512:607:: with SMTP id b7mr2082726lfe.489.1636580303716; Wed, 10 Nov 2021 13:38:23 -0800 (PST) MIME-Version: 1.0 References: <20211104133735.1223989-1-arnd@kernel.org> In-Reply-To: <20211104133735.1223989-1-arnd@kernel.org> From: Nick Desaulniers Date: Wed, 10 Nov 2021 13:38:11 -0800 Message-ID: Subject: Re: [PATCH] iwlwifi: pcie: fix constant-conversion warning To: Arnd Bergmann Cc: Luca Coelho , Kalle Valo , "David S. Miller" , Jakub Kicinski , Johannes Berg , Arnd Bergmann , Nathan Chancellor , Yaara Baruch , Matti Gottlieb , Emmanuel Grumbach , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Nov 4, 2021 at 6:37 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang points out a potential issue with integer overflow when > the iwl_dev_info_table[] array is empty: > > drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion] > for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) { > ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > > This is still harmless, as the loop correctly terminates, but adding > an (int) cast makes that clearer to the compiler. > > Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()") > Signed-off-by: Arnd Bergmann > --- > drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c > index c574f041f096..81e8f2fc4982 100644 > --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c > +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c > @@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device, > { > int i; > > - for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) { > + for (i = (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) { Perhaps `i` could be a `size_t` instead of an `int`? size_t i = ARRAY_SIZE(iwl_dev_info_table); while (i--) { ... > const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i]; > > if (dev_info->device != (u16)IWL_CFG_ANY && > -- > 2.29.2 > -- Thanks, ~Nick Desaulniers