* [PATCH] libertas_tf: lower the debug level of command trace
@ 2019-02-10 19:47 Lubomir Rintel
2019-02-11 13:23 ` Steve deRosier
2019-02-19 15:10 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lubomir Rintel @ 2019-02-10 19:47 UTC (permalink / raw)
To: Kalle Valo; +Cc: David S. Miller, linux-wireless, linux-kernel, Lubomir Rintel
Logging each and every command response is way too much for INFO level.
Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
index 909ac3685010..64b147dd2432 100644
--- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
+++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
@@ -737,10 +737,9 @@ int lbtf_process_rx_command(struct lbtf_private *priv)
respcmd = le16_to_cpu(resp->command);
result = le16_to_cpu(resp->result);
- if (net_ratelimit())
- pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
- respcmd, le16_to_cpu(resp->seqnum),
- le16_to_cpu(resp->size));
+ lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
+ respcmd, le16_to_cpu(resp->seqnum),
+ le16_to_cpu(resp->size));
if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
spin_unlock_irqrestore(&priv->driver_lock, flags);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libertas_tf: lower the debug level of command trace
2019-02-10 19:47 [PATCH] libertas_tf: lower the debug level of command trace Lubomir Rintel
@ 2019-02-11 13:23 ` Steve deRosier
2019-02-19 15:10 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Steve deRosier @ 2019-02-11 13:23 UTC (permalink / raw)
To: Lubomir Rintel; +Cc: Kalle Valo, David S. Miller, linux-wireless, LKML
On Sun, Feb 10, 2019 at 11:47 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> index 909ac3685010..64b147dd2432 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> @@ -737,10 +737,9 @@ int lbtf_process_rx_command(struct lbtf_private *priv)
> respcmd = le16_to_cpu(resp->command);
> result = le16_to_cpu(resp->result);
>
> - if (net_ratelimit())
> - pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> - respcmd, le16_to_cpu(resp->seqnum),
> - le16_to_cpu(resp->size));
> + lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> + respcmd, le16_to_cpu(resp->seqnum),
> + le16_to_cpu(resp->size));
>
> if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
> spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.20.1
>
Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libertas_tf: lower the debug level of command trace
2019-02-10 19:47 [PATCH] libertas_tf: lower the debug level of command trace Lubomir Rintel
2019-02-11 13:23 ` Steve deRosier
@ 2019-02-19 15:10 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-02-19 15:10 UTC (permalink / raw)
To: Lubomir Rintel
Cc: David S. Miller, linux-wireless, linux-kernel, Lubomir Rintel
Lubomir Rintel <lkundrak@v3.sk> wrote:
> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
Patch applied to wireless-drivers-next.git, thanks.
744972b2c4d2 libertas_tf: lower the debug level of command trace
--
https://patchwork.kernel.org/patch/10804873/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-19 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-10 19:47 [PATCH] libertas_tf: lower the debug level of command trace Lubomir Rintel
2019-02-11 13:23 ` Steve deRosier
2019-02-19 15:10 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).