From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5045DC4332F for ; Wed, 19 Jan 2022 15:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355741AbiASPbE (ORCPT ); Wed, 19 Jan 2022 10:31:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355739AbiASPan (ORCPT ); Wed, 19 Jan 2022 10:30:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A274AC06173F; Wed, 19 Jan 2022 07:30:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F5CF61506; Wed, 19 Jan 2022 15:30:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79287C340F7; Wed, 19 Jan 2022 15:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642606242; bh=OLrV/mw6WcIgeLQa2HMwTaMX8b3pt7TE+xb2FHEMCV8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JgmcjLsM6Gk2PSKImbxj26Qhy6USBLcVwdWBb5lOL2BuvJdLqnvmI1mrDBR7Gc2NG SHk21GkjadAmjjhdYDG9vq63f5F11r0UkffNBWH8VoykqWLLEjr2u9nIQIsh0B+87Z +dFhkgSjWASpFTmd+Bxx3VSjYyK4GcFfXns351+7xLiXyCQ81CCdJPRTcYtfSHVV5t BvjboJtxG3wo3Q6d0qQkQ9F4KukrC27L+PNjZoQsFMyOoQT8BcyXt7AWoLxyJwy00f xHP+xMIPOKl12FHwyQgV/AUp95wjom6igJ9X2h/kuGjjnouVqGUM36B7grcBtYDGgB qW94ZftrDj4ZQ== Received: by mail-ed1-f50.google.com with SMTP id c24so11415648edy.4; Wed, 19 Jan 2022 07:30:42 -0800 (PST) X-Gm-Message-State: AOAM5334vNiSZr9UpUfha0QWXYSyKaQ1Ibx5q3CRwIBk2jRZB2FfT5F5 4J/w/F+7PEoeJk0RBYKuw9qWCTDngk4h7GUFvQ== X-Google-Smtp-Source: ABdhPJyPYQrXxNSnCkTl5v8yMxjogVTk6EpzYA73WuLgFBNs1oJt1pAj6k4kUcCi7ejRXOlSTI1mdHZMJ5Kr9aWFF9o= X-Received: by 2002:aa7:c587:: with SMTP id g7mr27455803edq.109.1642606240687; Wed, 19 Jan 2022 07:30:40 -0800 (PST) MIME-Version: 1.0 References: <20220119015038.2433585-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Wed, 19 Jan 2022 09:30:28 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: Improve phandle-array schemas To: Arnaud POULIQUEN Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Damien Le Moal , Herbert Xu , "David S. Miller" , Chun-Kuang Hu , Philipp Zabel , Laurent Pinchart , Kieran Bingham , Vinod Koul , Georgi Djakov , Thomas Gleixner , Marc Zyngier , Joerg Roedel , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Mauro Carvalho Chehab , Krzysztof Kozlowski , Jakub Kicinski , Wolfgang Grandegger , Marc Kleine-Budde , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Kalle Valo , Viresh Kumar , Stephen Boyd , Kishon Vijay Abraham I , Linus Walleij , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Sebastian Reichel , Mark Brown , Mathieu Poirier , Daniel Lezcano , Zhang Rui , Greg Kroah-Hartman , Thierry Reding , Jonathan Hunter , Sudeep Holla , Geert Uytterhoeven , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , dri-devel , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , "open list:THERMAL" , Linux IOMMU , Linux LED Subsystem , Linux Media Mailing List , netdev , linux-can@vger.kernel.org, linux-wireless , "open list:GENERIC PHY FRAMEWORK" , "open list:GPIO SUBSYSTEM" , linux-riscv , "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" , Linux-ALSA , Linux USB List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jan 19, 2022 at 9:22 AM Arnaud POULIQUEN wrote: > > Hello Rob, > > On 1/19/22 2:50 AM, Rob Herring wrote: > > The 'phandle-array' type is a bit ambiguous. It can be either just an > > array of phandles or an array of phandles plus args. Many schemas for > > phandle-array properties aren't clear in the schema which case applies > > though the description usually describes it. > > > > The array of phandles case boils down to needing: > > > > items: > > maxItems: 1 > > > > The phandle plus args cases should typically take this form: > > > > items: > > - items: > > - description: A phandle > > - description: 1st arg cell > > - description: 2nd arg cell > > > > With this change, some examples need updating so that the bracketing of > > property values matches the schema. > > > > Cc: Damien Le Moal > > Cc: Herbert Xu > > Cc: "David S. Miller" > > Cc: Chun-Kuang Hu > > Cc: Philipp Zabel > > Cc: Laurent Pinchart > > Cc: Kieran Bingham > > Cc: Vinod Koul > > Cc: Georgi Djakov > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Joerg Roedel > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Pavel Machek > > Cc: Mauro Carvalho Chehab > > Cc: Krzysztof Kozlowski > > Cc: Jakub Kicinski > > Cc: Wolfgang Grandegger > > Cc: Marc Kleine-Budde > > Cc: Andrew Lunn > > Cc: Vivien Didelot > > Cc: Florian Fainelli > > Cc: Vladimir Oltean > > Cc: Kalle Valo > > Cc: Viresh Kumar > > Cc: Stephen Boyd > > Cc: Kishon Vijay Abraham I > > Cc: Linus Walleij > > Cc: "Rafael J. Wysocki" > > Cc: Kevin Hilman > > Cc: Ulf Hansson > > Cc: Sebastian Reichel > > Cc: Mark Brown > > Cc: Mathieu Poirier > > Cc: Daniel Lezcano > > Cc: Zhang Rui > > Cc: Greg Kroah-Hartman > > Cc: Thierry Reding > > Cc: Jonathan Hunter > > Cc: Sudeep Holla > > Cc: Geert Uytterhoeven > > Cc: linux-ide@vger.kernel.org > > Cc: linux-crypto@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: dmaengine@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > Cc: iommu@lists.linux-foundation.org > > Cc: linux-leds@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Cc: linux-can@vger.kernel.org > > Cc: linux-wireless@vger.kernel.org > > Cc: linux-phy@lists.infradead.org > > Cc: linux-gpio@vger.kernel.org > > Cc: linux-riscv@lists.infradead.org > > Cc: linux-remoteproc@vger.kernel.org > > Cc: alsa-devel@alsa-project.org > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > [...] > > > .../bindings/remoteproc/st,stm32-rproc.yaml | 33 ++++++-- > > [...] > > > diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > > index b587c97c282b..be3d9b0e876b 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml > > @@ -29,17 +29,22 @@ properties: > > > > st,syscfg-holdboot: > > description: remote processor reset hold boot > > - - Phandle of syscon block. > > - - The offset of the hold boot setting register. > > - - The field mask of the hold boot. > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > - maxItems: 1 > > + items: > > + - items: > > + - description: Phandle of syscon block > > + - description: The offset of the hold boot setting register > > + - description: The field mask of the hold boot > > > > st,syscfg-tz: > > description: > > Reference to the system configuration which holds the RCC trust zone mode > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > - maxItems: 1 > > + items: > > + - items: > > + - description: Phandle of syscon block > > + - description: FIXME > > + - description: FIXME > > - description: The offset of the trust zone setting register > - description: The field mask of the trust zone state > > > > > interrupts: > > description: Should contain the WWDG1 watchdog reset interrupt > > @@ -93,20 +98,32 @@ properties: > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > description: | > > Reference to the system configuration which holds the remote > > - maxItems: 1 > > + items: > > + - items: > > + - description: Phandle of syscon block > > + - description: FIXME > > + - description: FIXME > > - description: The offset of the power setting register > - description: The field mask of the PDDS selection > > > > > st,syscfg-m4-state: > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > description: | > > Reference to the tamp register which exposes the Cortex-M4 state. > > - maxItems: 1 > > + items: > > + - items: > > + - description: Phandle of syscon block with the tamp register > > + - description: FIXME > > + - description: FIXME > > - description: The offset of the tamp register > - description: The field mask of the Cortex-M4 state > > > > > st,syscfg-rsc-tbl: > > $ref: "/schemas/types.yaml#/definitions/phandle-array" > > description: | > > Reference to the tamp register which references the Cortex-M4 > > resource table address. > > - maxItems: 1 > > + items: > > + - items: > > + - description: Phandle of syscon block with the tamp register > > + - description: FIXME > > + - description: FIXME > > - description: The offset of the tamp register > - description: The field mask of the Cortex-M4 resource table address > > Please tell me if you prefer that I fix this in a dedicated patch. Thanks! I'll fold this into this patch. Rob