From: Taehee Yoo <ap420073@gmail.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: "David Miller" <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
linux-wireless@vger.kernel.org,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
j.vosburgh@gmail.com, vfalico@gmail.com,
"Andy Gospodarek" <andy@greyhouse.net>,
"Jiří Pírko" <jiri@resnulli.us>,
"Roopa Prabhu" <roopa@cumulusnetworks.com>,
saeedm@mellanox.com, manishc@marvell.com, rahulv@marvell.com,
kys@microsoft.com, haiyangz@microsoft.com,
"Stephen Hemminger" <stephen@networkplumber.org>,
sashal@kernel.org, hare@suse.de, varun@chelsio.com,
ubraun@linux.ibm.com, kgraul@linux.ibm.com,
"Jay Vosburgh" <jay.vosburgh@canonical.com>,
"Cody Schuffelen" <schuffelen@google.com>,
bjorn@mork.no
Subject: Re: [PATCH net v4 12/12] virt_wifi: fix refcnt leak in module exit routine
Date: Tue, 8 Oct 2019 15:53:48 +0900 [thread overview]
Message-ID: <CAMArcTXi5kamtSO28SX4NdjOvHYiEYRCMARUXhdKM9UUhk78rQ@mail.gmail.com> (raw)
In-Reply-To: <20191007112215.GA1288400@bistromath.localdomain>
On Mon, 7 Oct 2019 at 20:22, Sabrina Dubroca <sd@queasysnail.net> wrote:
>
Hi Sabrina,
Thank you for the review!
> 2019-09-28, 16:48:43 +0000, Taehee Yoo wrote:
> > virt_wifi_newlink() calls netdev_upper_dev_link() and it internally
> > holds reference count of lower interface.
> >
> > Current code does not release a reference count of the lower interface
> > when the lower interface is being deleted.
> > So, reference count leaks occur.
> >
> > Test commands:
> > ip link add dummy0 type dummy
> > ip link add vw1 link dummy0 type virt_wifi
>
> There should also be "ip link del dummy0" in this reproducer, right?
>
> [...]
>
> > @@ -598,14 +634,24 @@ static int __init virt_wifi_init_module(void)
> > /* Guaranteed to be locallly-administered and not multicast. */
> > eth_random_addr(fake_router_bssid);
> >
> > + err = register_netdevice_notifier(&virt_wifi_notifier);
> > + if (err)
> > + return err;
> > +
>
> Here err is 0.
>
> > common_wiphy = virt_wifi_make_wiphy();
> > if (!common_wiphy)
> > - return -ENOMEM;
> > + goto notifier;
>
> err is still 0 when we jump...
>
> > err = rtnl_link_register(&virt_wifi_link_ops);
> > if (err)
> > - virt_wifi_destroy_wiphy(common_wiphy);
> > + goto destroy_wiphy;
> >
> > + return 0;
> > +
> > +destroy_wiphy:
> > + virt_wifi_destroy_wiphy(common_wiphy);
> > +notifier:
> > + unregister_netdevice_notifier(&virt_wifi_notifier);
> > return err;
> > }
>
> ... so now we return 0 on failure. Can you add an "err = -ENOMEM"
> before "common_wiphy = ..."?
>
You're right, I will fix this in a v5 patch!
Thanks!
> Thanks.
>
> --
> Sabrina
next prev parent reply other threads:[~2019-10-08 6:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-28 16:48 [PATCH net v4 00/12] net: fix nested device bugs Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 01/12] net: core: limit nested device depth Taehee Yoo
2019-09-28 19:36 ` Johannes Berg
2019-09-29 11:05 ` Taehee Yoo
2019-10-01 7:11 ` Johannes Berg
2019-10-01 13:53 ` Taehee Yoo
2019-10-01 13:57 ` Johannes Berg
2019-10-01 18:23 ` Taehee Yoo
2019-10-10 10:19 ` Sabrina Dubroca
2019-10-12 11:42 ` Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 02/12] vlan: use dynamic lockdep key instead of subclass Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 03/12] bonding: fix unexpected IFF_BONDING bit unset Taehee Yoo
2019-09-30 20:48 ` Jay Vosburgh
2019-09-28 16:48 ` [PATCH net v4 04/12] bonding: use dynamic lockdep key instead of subclass Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 05/12] team: use dynamic lockdep key instead of static key Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 06/12] macsec: use dynamic lockdep key instead of subclass Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 07/12] macvlan: " Taehee Yoo
2019-09-28 19:14 ` Johannes Berg
2019-09-29 8:03 ` Taehee Yoo
2019-10-01 7:25 ` Johannes Berg
2019-10-05 9:13 ` Taehee Yoo
2019-10-07 11:41 ` Johannes Berg
2019-10-08 8:13 ` Taehee Yoo
2019-10-21 16:00 ` Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 08/12] macsec: fix refcnt leak in module exit routine Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 09/12] net: core: add ignore flag to netdev_adjacent structure Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 10/12] vxlan: add adjacent link to limit depth level Taehee Yoo
2019-09-28 16:48 ` [PATCH net v4 11/12] net: remove unnecessary variables and callback Taehee Yoo
2019-09-28 19:42 ` Johannes Berg
2019-09-28 16:48 ` [PATCH net v4 12/12] virt_wifi: fix refcnt leak in module exit routine Taehee Yoo
2019-09-28 18:57 ` Johannes Berg
2019-10-07 11:22 ` Sabrina Dubroca
2019-10-08 6:53 ` Taehee Yoo [this message]
2019-09-28 19:20 ` [PATCH net v4 00/12] net: fix nested device bugs Johannes Berg
2019-09-29 8:31 ` Taehee Yoo
2019-10-01 7:39 ` Johannes Berg
2019-10-05 9:40 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMArcTXi5kamtSO28SX4NdjOvHYiEYRCMARUXhdKM9UUhk78rQ@mail.gmail.com \
--to=ap420073@gmail.com \
--cc=andy@greyhouse.net \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=hare@suse.de \
--cc=j.vosburgh@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jay.vosburgh@canonical.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kgraul@linux.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-wireless@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rahulv@marvell.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sashal@kernel.org \
--cc=schuffelen@google.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
--cc=ubraun@linux.ibm.com \
--cc=varun@chelsio.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).