From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8FE3C433DF for ; Fri, 31 Jul 2020 14:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A306E206DA for ; Fri, 31 Jul 2020 14:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zWfvmpLd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387430AbgGaOGj (ORCPT ); Fri, 31 Jul 2020 10:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730799AbgGaOGi (ORCPT ); Fri, 31 Jul 2020 10:06:38 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51677C061574 for ; Fri, 31 Jul 2020 07:06:38 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id n2so22443574edr.5 for ; Fri, 31 Jul 2020 07:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9XeMSOu/cNN2dWpBgsvaLCWuwiunaIF0Gm0EXR6KiSA=; b=zWfvmpLdagwNE3esm2rxRXRkB7YZAvW42qd61qngQSFkgbm9SewSHX22BoF7ipqbNt G4UoBxHJzbuYcKP546F+nKl0Tm1VBBsz9AJj0jHuhC1Z2sUYRpV1iO+g44OxfARTFVg+ w7lXJxyQR83d7PltKgdRUMB4QbAb28onDm/BMZuAnLPrxKgz28tNrbRFH/iXGDDx7rQk waXf99LtdFBkaCV2w/rwA/xqUwJdTRepqnxUOgJ6hJp8eNmRYqxI8yljrmggpH/aj/7Y wAyNr0axK5jLmj5tW1oeqFYHQYM0gmnGyqcHeLvl0NBhTY64U/IKRjXk57lwhAgTkaXB vQfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9XeMSOu/cNN2dWpBgsvaLCWuwiunaIF0Gm0EXR6KiSA=; b=pAP6HyqKEyjodAEX9x4f1yNrW5Fl1ikBE6UwrYelzW7TxUbJmXsE+aNCPNv1LHUg5l K4xAFlD/P2IHYFuC57Elrv03dfG9TULGWf7GIgkRe691MME4LPATHFWaWi2uES/T05vz FB5VfzPU0FR92Wir138Dkwe8EOK9mI8Dq8e960tP1JH6SvIoLCJ9CKKyc69GTUg7aZAI bYYzx4n3Clto/ZnYsl0LIuc5Ner7zLuAf4pGmlD9XYL4xauwcJI2A1RYPGIm9v7srFFg 2TkO6jRq8QtJjHvlbfKpy69gQ3bqwpUty+0bJmBq77orDmtyIX/bPcqFDG9u3EJdvt1g yvsg== X-Gm-Message-State: AOAM532xuF2o99hUkFsckIpnfja6vknNJb4dG8DNCH0Z18Xoh8I0Rgoc sK6d1jC70bbeZqL4MXZHMikMMHnarNiAoFN5bKKcYu+1 X-Google-Smtp-Source: ABdhPJwv59u44/W6eUKRt6Youj1KSym9oeOj9Ak7FCnevKtp7rg/VbYd7p52YG8tannsVP/T3lHDeZJcHEkgTE3DYoU= X-Received: by 2002:aa7:d5d0:: with SMTP id d16mr3925942eds.212.1596204397008; Fri, 31 Jul 2020 07:06:37 -0700 (PDT) MIME-Version: 1.0 References: <20200731020157.744145-1-bryan.odonoghue@linaro.org> In-Reply-To: <20200731020157.744145-1-bryan.odonoghue@linaro.org> From: Loic Poulain Date: Fri, 31 Jul 2020 16:11:21 +0200 Message-ID: Subject: Re: [PATCH] wcn36xx: Set sw-scan chan to 0 when not associated To: "Bryan O'Donoghue" Cc: Kalle Valo , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 31 Jul 2020 at 04:01, Bryan O'Donoghue wrote: > > A patch in ath/pending rewrites the software scan for the wcn36xx to > accommodate multiplexing with data, link monitoring and so on. > > However if a device disassociates from an AP then the last operating > channel will not be re-scanned. > > After some discussion and testing on this topic > > https://www.spinics.net/lists/linux-wireless/msg201242.html > https://www.spinics.net/lists/linux-wireless/msg201254.html > > this patch implements a relatively simple fix. It sets the initial software > scan channel to 0 if we are not associated with an AP or to the current > operating channel if we are assciated with an AP. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/net/wireless/ath/wcn36xx/main.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) That looks good to me, that will force regular scanning on all channels when disconnected from AP. Reviewed-by: Loic Poulain