From: Loic Poulain <loic.poulain@linaro.org>
To: Benjamin Li <benl@squareup.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy rates
Date: Wed, 3 Nov 2021 18:08:15 +0100 [thread overview]
Message-ID: <CAMZdPi8c1aJCCL8b6iYSz1Ev46jK15Fpa9pG-2FGhrT3FR2RMA@mail.gmail.com> (raw)
In-Reply-To: <20211103155543.1037604-3-benl@squareup.com>
Hi Ben,
On Wed, 3 Nov 2021 at 16:56, Benjamin Li <benl@squareup.com> wrote:
>
> The linear mapping between the BD rate field and the driver's 5GHz
> legacy rates table (wcn_5ghz_rates) does not only apply for the latter
> four rates -- it applies to all eight rates.
>
> Fixes: 6ea131acea98 ("wcn36xx: Fix warning due to bad rate_idx")
> Signed-off-by: Benjamin Li <benl@squareup.com>
> ---
> drivers/net/wireless/ath/wcn36xx/txrx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/txrx.c b/drivers/net/wireless/ath/wcn36xx/txrx.c
> index f0a9f069a92a9..fce3a6a98f596 100644
> --- a/drivers/net/wireless/ath/wcn36xx/txrx.c
> +++ b/drivers/net/wireless/ath/wcn36xx/txrx.c
> @@ -272,7 +272,6 @@ int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
> const struct wcn36xx_rate *rate;
> struct ieee80211_hdr *hdr;
> struct wcn36xx_rx_bd *bd;
> - struct ieee80211_supported_band *sband;
> u16 fc, sn;
>
> /*
> @@ -350,12 +349,10 @@ int wcn36xx_rx_skb(struct wcn36xx *wcn, struct sk_buff *skb)
> status.enc_flags = rate->encoding_flags;
> status.bw = rate->bw;
> status.rate_idx = rate->mcs_or_legacy_index;
> - sband = wcn->hw->wiphy->bands[status.band];
> status.nss = 1;
>
> if (status.band == NL80211_BAND_5GHZ &&
> - status.encoding == RX_ENC_LEGACY &&
> - status.rate_idx >= sband->n_bitrates) {
It looks fine, but can you replace it with a 'status.rate_idx >= 4'.
I get sporadic 5Ghz frames reported with rate_idx=0 (firmware miss?),
leading to warnings because status.rate_idx is -4(unsigned) in that
case. So better to report a wrong rate than a corrupted one.
>
> + status.encoding == RX_ENC_LEGACY) {
> /* no dsss rates in 5Ghz rates table */
> status.rate_idx -= 4;
> }
> --
Regards,
Loic
next prev parent reply other threads:[~2021-11-03 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 15:55 [PATCH v2 0/2] wcn36xx: populate band before determining rate on RX Benjamin Li
2021-11-03 15:55 ` [PATCH v2 1/2] " Benjamin Li
2021-11-03 15:55 ` [PATCH v2 2/2] wcn36xx: fix RX BD rate mapping for 5GHz legacy rates Benjamin Li
2021-11-03 17:08 ` Loic Poulain [this message]
2021-11-03 17:01 ` Benjamin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZdPi8c1aJCCL8b6iYSz1Ev46jK15Fpa9pG-2FGhrT3FR2RMA@mail.gmail.com \
--to=loic.poulain@linaro.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).