From: Emmanuel Grumbach <egrumbach@gmail.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: How to disable beacon filtering in iwlwifi in 3.13 and 3.14
Date: Mon, 19 May 2014 13:40:34 +0300 [thread overview]
Message-ID: <CANUX_P2MSK_rUMyN2xa8A9dZwuPSKh+eiOr10KG6PocCQdVhvA@mail.gmail.com> (raw)
Hi,
I need to disable a feature on 3.13 and 3.14. But I don't have any
patch upstream that I can point to as the patch that needs to be
backported.
We have a feature that is buggy in 3.13 and 3.14. We refactored (and
fixed) this feature in 3.15 but the refactor is really not stable
material, so basically, I can't backport the fix to 3.13 / 3.14. A
user reported that disabling the feature solved (part of) his issues:
https://bugzilla.kernel.org/show_bug.cgi?id=72601.
OTOH, I don't have any patch in linux.git that could be backported to
do what I want in 3.13 / 3.14 - i.e. disable the feature.
What is the right process here? I understand that this isn't covered
by the "stable rules". So what should I do here?
FYI: this is the patch:
commit 31e56634bea6ab23817faa069663af3103da0609
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Date: Sun May 18 19:05:23 2014 +0300
iwlwifi: mvm: disable beacon filtering
This feature has been causing trouble - disable it for now.
Fixes are available, but they are too big to be backported.
https://bugzilla.kernel.org/show_bug.cgi?id=72601
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c
b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
index cd6ea2e..17c097d 100644
--- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c
@@ -619,7 +619,7 @@ static int iwl_mvm_mac_add_interface(struct
ieee80211_hw *hw,
if (ret)
goto out_remove_mac;
- if (!mvm->bf_allowed_vif &&
+ if (!mvm->bf_allowed_vif && false &&
vif->type == NL80211_IFTYPE_STATION && !vif->p2p &&
mvm->fw->ucode_capa.flags & IWL_UCODE_TLV_FLAGS_BF_UPDATED){
mvm->bf_allowed_vif = mvmvif;
Emmanuel Grumbach
egrumbach@gmail.com
next reply other threads:[~2014-05-19 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 10:40 Emmanuel Grumbach [this message]
2014-05-19 19:41 ` How to disable beacon filtering in iwlwifi in 3.13 and 3.14 Greg KH
2014-05-19 20:23 ` Emmanuel Grumbach
2014-05-19 21:15 ` Greg KH
2014-05-19 20:29 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANUX_P2MSK_rUMyN2xa8A9dZwuPSKh+eiOr10KG6PocCQdVhvA@mail.gmail.com \
--to=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).