From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD400C433DF for ; Fri, 22 May 2020 05:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACF122073B for ; Fri, 22 May 2020 05:13:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c7FN9I59" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728161AbgEVFNP (ORCPT ); Fri, 22 May 2020 01:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728056AbgEVFNO (ORCPT ); Fri, 22 May 2020 01:13:14 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6534AC061A0E; Thu, 21 May 2020 22:13:14 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id t4so3489080vsq.0; Thu, 21 May 2020 22:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5yruC8ieiL7TwqkjRWBVMs7ndKJLZVQiNT3lPw/qOQU=; b=c7FN9I59JUxb822cpZyKQ+6QJIVWr664KHk0nWlcyZuW78SmKtEQN4zjlm51LdGU5g sPunvgH6DLTo6nxtmbrGaUgTML2n+aCw4nUAlfpYvGdCYB7ywLdfLhcrExyn+u9r1mXN z8vr3MLiiL76ZoBiFT4BBjkgquS482zfHeHqMY2IILiPQ1bkaX87zV7D9mMdv+sOcruL iQPCFTchyw9KNXeVLw3StTdhJ9JxBxlBcvhDi/FzuQj+4MY6VE2rRA7nLl9y0WrEY+O2 vbcvKIrsZsgQEzUrlcaHhrPr2+k6mOTFQ/+QJ/gt326m8qBXUGXY/4JDjlP9Fi1ih8F8 gOew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5yruC8ieiL7TwqkjRWBVMs7ndKJLZVQiNT3lPw/qOQU=; b=Re7U5ytEUbfRuhMbuQT9TlYse3mARKHQv1tNstGk/Tfne/EPZZcIUvHYyn/x872l6E MI//01Iuf9z966kI400H7soFeQmz2C3LIcQS/ds2bk+l3VwAljJXMS07uYGDSN1XaSxU 3c+fiNTf95Kl7lCd+s+bT7SNxDpf/3T6Ea8XsDKWaARBqJlY1+jXy819vxpMYnejeGhY Se8G6o+z23yO+1ccEvb42ndHkd+v0T5clmRDmMIlq9UEXGIeyIaId8LJ/ZmShW70TVpv c1QIO9NHdNVOrvRN/mCPRPmFFo5pBphwkDWNxhqHSCgeTJWPnJJVBPIY/pES+03yzH7b gHIw== X-Gm-Message-State: AOAM532dzmcB2oiAqWWUYaIRjKO+hckMkN6Rqzs3VoIFqt7oRWk7ImYe HhILCezRbdR/sEsZltsCtLel7LJ9haiZyiiq64w= X-Google-Smtp-Source: ABdhPJx4y6XBRLuJWpzhO9R+CVeML+3mw72czhbPk8Iy3pZZs2RyIznn03Q1GFw5Ow9OKiHxuoaccU4/GzNA2iatku8= X-Received: by 2002:a67:684a:: with SMTP id d71mr9346812vsc.176.1590124392684; Thu, 21 May 2020 22:13:12 -0700 (PDT) MIME-Version: 1.0 References: <20200515212846.1347-1-mcgrof@kernel.org> <20200515212846.1347-13-mcgrof@kernel.org> <2b74a35c726e451b2fab2b5d0d301e80d1f4cdc7.camel@sipsolutions.net> <7306323c35e6f44d7c569e689b48f380f80da5e5.camel@sipsolutions.net> <20200519140212.GT11244@42.do-not-panic.com> In-Reply-To: From: Emmanuel Grumbach Date: Fri, 22 May 2020 08:12:59 +0300 Message-ID: Subject: Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed() To: Brian Norris Cc: Luis Chamberlain , Johannes Berg , linux-wireless , aquini@redhat.com, peterz@infradead.org, Daniel Vetter , mchehab+samsung@kernel.org, will@kernel.org, bhe@redhat.com, ath10k@lists.infradead.org, Takashi Iwai , mingo@redhat.com, dyoung@redhat.com, pmladek@suse.com, Kees Cook , Arnd Bergmann , gpiccoli@canonical.com, Steven Rostedt , cai@lca.pw, tglx@linutronix.de, Andy Shevchenko , Kalle Valo , "" , schlad@suse.de, Linux Kernel , jeyu@kernel.org, Andrew Morton , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > > On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach wrote: > > So I believe we already have this uevent, it is the devcoredump. All > > we need is to add the unique id. > > I think there are a few reasons that devcoredump doesn't satisfy what > either Luis or I want. > > 1) it can be disabled entirely [1], for good reasons (e.g., think of > non-${CHIP_VENDOR} folks, who can't (and don't want to) do anything > with the opaque dumps provided by closed-source firmware) Ok, if all you're interested into is the information that this event happen (as opposed to report a bug and providing the data), then I agree. True, not everybody want or can enable devcoredump. I am just a bit concerned that we may end up with two interface that notify the same event basically. The ideal maybe would be to be able to optionally reduce the content of the devoredump to nothing more that is already in the dmesg output. But then, it is not what it is meant to be: namely, a core dump.. > 2) not all drivers necessarily have a useful dump to provide when > there's a crash; look at the rest of Luis's series to see the kinds of > drivers-with-firmware that are crashing, some of which aren't dumping > anything Fair enouh. > 3) for those that do support devcoredump, it may be used for purposes > that are not "crashes" -- e.g., some provide debugfs or other knobs to > initiate dumps, for diagnostic or debugging purposes Not sure I really think we need to care about those cases, but you already have 2 good arguments :) > > Brian > > [1] devcd_disabled > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/devcoredump.c?h=v5.6#n22