From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kvalo@kernel.org, Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next] net: drop the weight argument from netif_napi_add
Date: Tue, 27 Sep 2022 11:38:36 -0700 [thread overview]
Message-ID: <CANn89iKujNcWC7jLRN_6cTCwadyt7Hid6i39i3g3gKwBUvGovg@mail.gmail.com> (raw)
In-Reply-To: <20220927111758.1d25ea0f@kernel.org>
On Tue, Sep 27, 2022 at 11:18 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 27 Sep 2022 10:54:49 -0700 Eric Dumazet wrote:
> > On Tue, Sep 27, 2022 at 6:28 AM Jakub Kicinski <kuba@kernel.org> wrote:
> > > We tell driver developers to always pass NAPI_POLL_WEIGHT
> > > as the weight to netif_napi_add(). This may be confusing
> > > to newcomers, drop the weight argument, those who really
> > > need to tweak the weight can use netif_napi_add_weight().
> > >
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> >
> > Sure, but this kind of patch makes backports harder.
> > Not sure how confused are newcomers about this NAPI_POLL_WEIGHT....
>
> I maintained this patch in my tree for a couple of releases (because
> I was waiting for the _weight() version to propagate to non-netdev
> trees) and the conflicts were minor. Three or so cases of new features
> added to drivers which touched the NAPI calls (WiFi and embedded) and
> the strlcpy -> strscpy patch, and, well, why did we take that in if we
> worry about backports...
>
> NAPI weight was already dead when I started hacking on the kernel
> 10 years ago. I don't think it's reasonable to keep dead stuff
> in our APIs for backport's sake. Adding Jiri to CC in case I need
> someone to back me up :)
>
> The idea for this patch came because I was reviewing a driver which
> was trying to do something clever with the weight.
>
No hard feelings, but the recent removal of netif_tx_napi_add() added
extra work for some of us ;)
Keeping around few helpers to keep API a bit stable would help I think.
next prev parent reply other threads:[~2022-09-27 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:27 [PATCH net-next] net: drop the weight argument from netif_napi_add Jakub Kicinski
2022-09-27 13:31 ` Marc Kleine-Budde
2022-09-27 15:54 ` Jason A. Donenfeld
2022-09-27 17:54 ` Eric Dumazet
2022-09-27 18:17 ` Jakub Kicinski
2022-09-27 18:38 ` Eric Dumazet [this message]
2022-09-27 18:26 ` Dave Taht
2022-09-29 2:20 ` patchwork-bot+netdevbpf
2022-10-02 17:24 ` Guenter Roeck
2022-10-02 17:59 ` Jakub Kicinski
2022-10-02 23:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iKujNcWC7jLRN_6cTCwadyt7Hid6i39i3g3gKwBUvGovg@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).