From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279DF2230A for ; Wed, 20 Dec 2023 11:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b9fVYFGg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703072015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GZvXo9n7E1BUG9QukBdJSLRTxHIpYEVliraJ+HgqD48=; b=b9fVYFGgzsupIl3ZGFiMbVCBZjibCB6GWG13j/5vqeYoIl/LRzjin4XywIkrrwWKxnmuQW K3kINiOxhSQ3+3GGsdwQfN25npYjDtDeT+HEzRWySxKOjRqBiiLLZezZd07J3XaYCIKsh+ 6X5AfIxnTC9Pkqo9LHOMi2TN4Bl/ge4= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-ONnFqpXOPSeDZ45Kp_x8tw-1; Wed, 20 Dec 2023 06:33:33 -0500 X-MC-Unique: ONnFqpXOPSeDZ45Kp_x8tw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5cdd4747877so284051a12.1 for ; Wed, 20 Dec 2023 03:33:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703072013; x=1703676813; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GZvXo9n7E1BUG9QukBdJSLRTxHIpYEVliraJ+HgqD48=; b=fFJnJCMsOz14IeOCmxs2VvOZG0mlXLEgfYzPRu2mWqRmbzRB4Frl5piDbGlrh8oBxY kvU4hq6khhrkjL5dfdJ2K8wtdFLmSbeL0JgfUmIaJAlIJcQr93jX+FrgnUWBCuaP3rix aBsDt1779U3TePHDK8dMT+RKNVqa2BqB5wCXat0M7l6ZsqXQ70u+JOXtqUWUYyeq4g4b tPBqRC8j9Ekc220EVuwT4vGNgJc+KsZOHOZdaqy+hpF3kxJF5VqOl3aAe0Q6b+0dZsEX 28ZL5a+jJmjiiv3Z8W73C8WGQsZ9vTbfK3w/erfslzZi2+POSw+JMu9JIny/lWwteZwR xGLg== X-Gm-Message-State: AOJu0Yz0wiwvNO1/Jp0ax9Oxs7rBkXx3fJ8bOcWbYRknKtBGNlde7QXh kePUvSdmD8yPmepG/0vmEVg6KKGxbnHwGrTkfuLRw/JKpawUhj111OzrJ2Cgk6khy7QgZaa2A0U OfQqEIvP8yY/qYtYmifEeSdf/B7RuyLtQGl8Gr8W9OhM= X-Received: by 2002:a17:90b:4f8b:b0:28b:cfea:c3a with SMTP id qe11-20020a17090b4f8b00b0028bcfea0c3amr915932pjb.39.1703072012769; Wed, 20 Dec 2023 03:33:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrvhx2+ke9fT+Ck2vv/eRkSRqKHgA3znkYCpalIpUXY7DbRWaaCOV/vGf7lKVHCsZIv8L3LHll2lJL8n/QSCE= X-Received: by 2002:a17:90b:4f8b:b0:28b:cfea:c3a with SMTP id qe11-20020a17090b4f8b00b0028bcfea0c3amr915916pjb.39.1703072012512; Wed, 20 Dec 2023 03:33:32 -0800 (PST) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231107-brcmfmac-wpa3-v1-1-4c7db8636680@marcan.st> <170281231651.2255653.7498073085103487666.kvalo@kernel.org> <18c80d15e30.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <1b51997f-2994-46e8-ac58-90106d1c486d@marcan.st> <87r0jiqmnx.fsf@kernel.org> <01bd8c68-1b9c-49b2-8ace-1c7d1b5192ad@marcan.st> In-Reply-To: From: Eric Curtin Date: Wed, 20 Dec 2023 11:32:56 +0000 Message-ID: Subject: Re: [PATCH] wifi: brcmfmac: cfg80211: Use WSEC to set SAE password To: Linus Torvalds Cc: Hector Martin , Kalle Valo , Daniel Berlin , Arend van Spriel , Arend van Spriel , Franky Lin , Hante Meuleman , SHA-cyfmac-dev-list@infineon.com, asahi@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, David Airlie , Daniel Vetter Content-Type: text/plain; charset="UTF-8" On Wed, 20 Dec 2023 at 01:54, Linus Torvalds wrote: > > On Tue, 19 Dec 2023 at 16:06, Hector Martin wrote: > > > > On 2023/12/19 23:42, Kalle Valo wrote: > > > > > > Why is it that every patch Hector submits seems to end up with flame > > > wars? > > Well, I do think some of it is Hector's personality and forceful > approaches, but I do think part of it is also the area in question. > > Because I do agree with Hector that.. > > > Just recently a patch was posted to remove the Infineon list from > > MAINTAINERS because that company cares so little they have literally > > stopped accepting emails from us. Meanwhile they are telling their > > customers that they do not recommend upstream brcmfmac and they should > > use their downstream driver [1]. > > Unquestionably broadcom is not helping maintain things, and I think it > should matter. > > As Hector says, they point to their random driver dumps on their site > that you can't even download unless you are a "Broadcom community > member" or whatever, and hey - any company that works that way should > be seen as pretty much hostile to any actual maintenance and proper > development. > > If Daniel and Hector are responsive to actual problem reports for the > changes they cause, I do think that should count a lot. > > I don't think Cypress support should necessarily be removed (or marked > broken), but if the sae_password code already doesn't work, _that_ > part certainly shouldn't hold things up? > > Put another way: if we effectively don't have a driver maintainer that > can test things, and somebody is willing to step up, shouldn't we take > that person up on it? I am trying to help try and find a maintainer in the community, but of course I can't guarantee anything. Theoretically of course it should be someone from Broadcom, Raspberry Pi, etc. and not the community (not that this helps unblock us promptly). I just would like to say this upstream Cypress driver has a large number of users via Fedora and CentOS Stream Automotive Distribution. And that's just the Fedora family of distros. But the Apple Silicon devices have a pretty large amount of users also. We need to find a way of accommodating both. If that's either fork the code into two separate files somehow or find another maintainer, I don't know (just my uninformed opinion). Is mise le meas/Regards, Eric Curtin > > Linus >