From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
"Kalle Valo" <kvalo@codeaurora.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org, "Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v9 08/24] wfx: add bus_sdio.c
Date: Wed, 12 Jan 2022 11:51:16 +0100 [thread overview]
Message-ID: <CAPDyKFoMQG-GOfRsMk21Awk21cxVN6bMe9n8YCh8xHbg7j1Rgg@mail.gmail.com> (raw)
In-Reply-To: <20220111171424.862764-9-Jerome.Pouiller@silabs.com>
[...]
> +static const struct of_device_id wfx_sdio_of_match[] = {
> + { .compatible = "silabs,wf200", .data = &pdata_wf200 },
> + { .compatible = "silabs,brd4001a", .data = &pdata_brd4001a },
> + { .compatible = "silabs,brd8022a", .data = &pdata_brd8022a },
> + { .compatible = "silabs,brd8023a", .data = &pdata_brd8023a },
> + { .compatible = "silabs,wfx-sdio", .data = &pdata_wfx_sdio },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, wfx_sdio_of_match);
> +
> +static int wfx_sdio_probe(struct sdio_func *func, const struct sdio_device_id *id)
> +{
> + const struct wfx_platform_data *pdata = of_device_get_match_data(&func->dev);
> + struct device_node *np = func->dev.of_node;
> + struct wfx_sdio_priv *bus;
> + int ret;
> +
> + if (func->num != 1) {
> + dev_err(&func->dev, "SDIO function number is %d while it should always be 1 (unsupported chip?)\n",
> + func->num);
> + return -ENODEV;
> + }
> +
> + if (!pdata) {
> + dev_warn(&func->dev, "no compatible device found in DT\n");
> + return -ENODEV;
> + }
> +
> + bus = devm_kzalloc(&func->dev, sizeof(*bus), GFP_KERNEL);
> + if (!bus)
> + return -ENOMEM;
> +
> + bus->func = func;
> + bus->of_irq = irq_of_parse_and_map(np, 0);
> + sdio_set_drvdata(func, bus);
> + func->card->quirks |= MMC_QUIRK_LENIENT_FN0 |
> + MMC_QUIRK_BLKSZ_FOR_BYTE_MODE |
> + MMC_QUIRK_BROKEN_BYTE_MODE_512;
This should not be needed any more, right?
> +
> + sdio_claim_host(func);
> + ret = sdio_enable_func(func);
> + /* Block of 64 bytes is more efficient than 512B for frame sizes < 4k */
> + sdio_set_block_size(func, 64);
> + sdio_release_host(func);
> + if (ret)
> + return ret;
> +
> + bus->core = wfx_init_common(&func->dev, pdata, &wfx_sdio_hwbus_ops, bus);
> + if (!bus->core) {
> + ret = -EIO;
> + goto sdio_release;
> + }
> +
> + ret = wfx_probe(bus->core);
> + if (ret)
> + goto sdio_release;
> +
> + return 0;
> +
> +sdio_release:
> + sdio_claim_host(func);
> + sdio_disable_func(func);
> + sdio_release_host(func);
> + return ret;
> +}
[...]
Other than the above, this looks good to me!
Kind regards
Uffe
next prev parent reply other threads:[~2022-01-12 10:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:14 [PATCH v9 00/24] wfx: get out from the staging area Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller
2022-01-12 10:58 ` Ulf Hansson
2022-01-12 12:45 ` Kalle Valo
2022-01-11 17:14 ` [PATCH v9 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller
2022-01-11 20:49 ` Rob Herring
2022-01-11 22:19 ` Rob Herring
2022-01-12 9:51 ` Jérôme Pouiller
2022-01-11 17:14 ` [PATCH v9 03/24] wfx: add Makefile/Kconfig Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 04/24] wfx: add wfx.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 05/24] wfx: add main.c/main.h Jerome Pouiller
2022-01-26 8:20 ` Jérôme Pouiller
2022-02-10 14:20 ` Kalle Valo
2022-02-10 14:41 ` Jérôme Pouiller
2022-02-10 14:51 ` Kalle Valo
2022-02-10 15:13 ` Jérôme Pouiller
2022-02-10 16:25 ` Kalle Valo
2022-02-10 16:37 ` Jérôme Pouiller
2022-02-11 7:08 ` Kalle Valo
2022-02-10 14:23 ` Pali Rohár
2022-01-11 17:14 ` [PATCH v9 06/24] wfx: add bus.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 07/24] wfx: add bus_spi.c Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 08/24] wfx: add bus_sdio.c Jerome Pouiller
2022-01-12 10:51 ` Ulf Hansson [this message]
2022-01-12 10:58 ` Pali Rohár
2022-01-12 11:18 ` Jérôme Pouiller
2022-01-12 11:43 ` Pali Rohár
2022-01-12 12:06 ` Greg Kroah-Hartman
2022-01-12 12:14 ` Pali Rohár
2022-01-12 15:03 ` Ulf Hansson
2022-01-12 16:45 ` Jérôme Pouiller
2022-01-12 17:48 ` Pali Rohár
2022-01-12 18:23 ` Jérôme Pouiller
2022-01-13 12:07 ` Ulf Hansson
2022-01-11 17:14 ` [PATCH v9 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 11/24] wfx: add bh.c/bh.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 12/24] wfx: add hif_api_*.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 14/24] wfx: add key.c/key.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 17/24] wfx: add queue.c/queue.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 19/24] wfx: add sta.c/sta.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 20/24] wfx: add scan.c/scan.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 21/24] wfx: add debug.c/debug.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 22/24] wfx: add traces.h Jerome Pouiller
2022-01-11 17:14 ` [PATCH v9 23/24] wfx: remove from the staging area Jerome Pouiller
2022-01-12 7:49 ` Kalle Valo
2022-01-12 9:32 ` Jérôme Pouiller
2022-01-12 12:46 ` Kalle Valo
2022-01-11 17:14 ` [PATCH v9 24/24] wfx: get out " Jerome Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoMQG-GOfRsMk21Awk21cxVN6bMe9n8YCh8xHbg7j1Rgg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).