* [PATCH] arm64: dts: hikey: Give wifi some time after power-on
@ 2018-12-30 11:38 Jan Kiszka
2019-01-02 22:21 ` John Stultz
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2018-12-30 11:38 UTC (permalink / raw)
To: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu
Cc: Ryan Grachek, John Stultz, linux-wireless, Reizer, Eyal,
Valentin Schneider
From: Jan Kiszka <jan.kiszka@siemens.com>
Somewhere along recent changes to power control of the wl1835, power-on
became very unreliable on the hikey, failing like this:
wl1271_sdio: probe of mmc2:0001:1 failed with error -16
wl1271_sdio: probe of mmc2:0001:2 failed with error -16
After playing with some dt parameters and comparing to other users of
this chip, it turned out we need some power-on delay to make things
stable again. In contrast to those other users which define 200 ms, the
hikey is already very happy with 1 ms.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Tested with 4.19 and linus/master.
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index f4964bee6a1a..1e771bf201b9 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -118,6 +118,7 @@
reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
clocks = <&pmic>;
clock-names = "ext_clock";
+ post-power-on-delay-ms = <1>;
power-off-delay-us = <10>;
};
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
2018-12-30 11:38 [PATCH] arm64: dts: hikey: Give wifi some time after power-on Jan Kiszka
@ 2019-01-02 22:21 ` John Stultz
2019-01-03 21:32 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: John Stultz @ 2019-01-02 22:21 UTC (permalink / raw)
To: Jan Kiszka
Cc: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu,
Ryan Grachek, linux-wireless, Reizer, Eyal, Valentin Schneider,
Tony Lindgren, Kalle Valo, KISHON VIJAY ABRAHAM, Mishol, Guy,
Anders Roxell, Ricardo Salveti, Ulf Hansson
Adding a few folks to cc from the thread here:
https://patchwork.kernel.org/patch/10734021/
As this sounds like a very similar issue.
thanks
-john
On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@web.de> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Somewhere along recent changes to power control of the wl1835, power-on
> became very unreliable on the hikey, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms, the
> hikey is already very happy with 1 ms.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> Tested with 4.19 and linus/master.
>
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index f4964bee6a1a..1e771bf201b9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -118,6 +118,7 @@
> reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> clocks = <&pmic>;
> clock-names = "ext_clock";
> + post-power-on-delay-ms = <1>;
> power-off-delay-us = <10>;
> };
>
> --
> 2.16.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
2019-01-02 22:21 ` John Stultz
@ 2019-01-03 21:32 ` Ulf Hansson
2019-01-06 9:53 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2019-01-03 21:32 UTC (permalink / raw)
To: John Stultz, Jan Kiszka
Cc: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu,
Ryan Grachek, linux-wireless, Reizer, Eyal, Valentin Schneider,
Tony Lindgren, Kalle Valo, KISHON VIJAY ABRAHAM, Mishol, Guy,
Anders Roxell, Ricardo Salveti
On Wed, 2 Jan 2019 at 23:21, John Stultz <john.stultz@linaro.org> wrote:
>
> Adding a few folks to cc from the thread here:
> https://patchwork.kernel.org/patch/10734021/
>
> As this sounds like a very similar issue.
> thanks
> -john
John, thanks for looping me in.
>
> On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@web.de> wrote:
> >
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Somewhere along recent changes to power control of the wl1835, power-on
> > became very unreliable on the hikey, failing like this:
> >
> > wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> > wl1271_sdio: probe of mmc2:0001:2 failed with error -16
> >
> > After playing with some dt parameters and comparing to other users of
> > this chip, it turned out we need some power-on delay to make things
> > stable again. In contrast to those other users which define 200 ms, the
> > hikey is already very happy with 1 ms.
According to the discussions we had so far, this doesn't sound like
the correct solution.
I am intending to post patch soon, however, I am not sure exactly what
solution to pick yet. I will keep you on cc - and of course I
appreciate if you could help to test.
Kind regards
Uffe
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >
> > Tested with 4.19 and linus/master.
> >
> > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> > b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> > index f4964bee6a1a..1e771bf201b9 100644
> > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> > @@ -118,6 +118,7 @@
> > reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
> > clocks = <&pmic>;
> > clock-names = "ext_clock";
> > + post-power-on-delay-ms = <1>;
> > power-off-delay-us = <10>;
> > };
> >
> > --
> > 2.16.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
2019-01-03 21:32 ` Ulf Hansson
@ 2019-01-06 9:53 ` Jan Kiszka
2019-01-15 8:10 ` Jan Kiszka
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2019-01-06 9:53 UTC (permalink / raw)
To: Ulf Hansson, John Stultz
Cc: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu,
Ryan Grachek, linux-wireless, Reizer, Eyal, Valentin Schneider,
Tony Lindgren, Kalle Valo, KISHON VIJAY ABRAHAM, Mishol, Guy,
Anders Roxell, Ricardo Salveti
On 03.01.19 22:32, Ulf Hansson wrote:
> On Wed, 2 Jan 2019 at 23:21, John Stultz <john.stultz@linaro.org> wrote:
>>
>> Adding a few folks to cc from the thread here:
>> https://patchwork.kernel.org/patch/10734021/
>>
>> As this sounds like a very similar issue.
>> thanks
>> -john
>
> John, thanks for looping me in.
>
>>
>> On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@web.de> wrote:
>>>
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> Somewhere along recent changes to power control of the wl1835, power-on
>>> became very unreliable on the hikey, failing like this:
>>>
>>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
>>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>>>
>>> After playing with some dt parameters and comparing to other users of
>>> this chip, it turned out we need some power-on delay to make things
>>> stable again. In contrast to those other users which define 200 ms, the
>>> hikey is already very happy with 1 ms.
>
> According to the discussions we had so far, this doesn't sound like
> the correct solution.
>
> I am intending to post patch soon, however, I am not sure exactly what
> solution to pick yet. I will keep you on cc - and of course I
> appreciate if you could help to test.
>
FWIW, the Ultra96 is also affected. Here I worked around it by using a 10 ms
power-on delay. The original workaround from the other thread did not help.
Looking forward to the proper fix now!
Jan
> Kind regards
> Uffe
>
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>
>>> Tested with 4.19 and linus/master.
>>>
>>> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>>> b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>>> index f4964bee6a1a..1e771bf201b9 100644
>>> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
>>> @@ -118,6 +118,7 @@
>>> reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>;
>>> clocks = <&pmic>;
>>> clock-names = "ext_clock";
>>> + post-power-on-delay-ms = <1>;
>>> power-off-delay-us = <10>;
>>> };
>>>
>>> --
>>> 2.16.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
2019-01-06 9:53 ` Jan Kiszka
@ 2019-01-15 8:10 ` Jan Kiszka
2019-01-15 8:13 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2019-01-15 8:10 UTC (permalink / raw)
To: Ulf Hansson, John Stultz
Cc: Linux Kernel Mailing List, linux-arm-kernel, Wei Xu,
Ryan Grachek, linux-wireless, Reizer, Eyal, Valentin Schneider,
Tony Lindgren, Kalle Valo, KISHON VIJAY ABRAHAM, Mishol, Guy,
Anders Roxell, Ricardo Salveti
On 06.01.19 10:53, Jan Kiszka wrote:
> On 03.01.19 22:32, Ulf Hansson wrote:
>> On Wed, 2 Jan 2019 at 23:21, John Stultz <john.stultz@linaro.org> wrote:
>>>
>>> Adding a few folks to cc from the thread here:
>>> https://patchwork.kernel.org/patch/10734021/
>>>
>>> As this sounds like a very similar issue.
>>> thanks
>>> -john
>>
>> John, thanks for looping me in.
>>
>>>
>>> On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@web.de> wrote:
>>>>
>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>>
>>>> Somewhere along recent changes to power control of the wl1835, power-on
>>>> became very unreliable on the hikey, failing like this:
>>>>
>>>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
>>>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>>>>
>>>> After playing with some dt parameters and comparing to other users of
>>>> this chip, it turned out we need some power-on delay to make things
>>>> stable again. In contrast to those other users which define 200 ms, the
>>>> hikey is already very happy with 1 ms.
>>
>> According to the discussions we had so far, this doesn't sound like
>> the correct solution.
>>
>> I am intending to post patch soon, however, I am not sure exactly what
>> solution to pick yet. I will keep you on cc - and of course I
>> appreciate if you could help to test.
>>
>
> FWIW, the Ultra96 is also affected. Here I worked around it by using a 10 ms
> power-on delay. The original workaround from the other thread did not help.
> Looking forward to the proper fix now!
>
Any news on this regression?
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: hikey: Give wifi some time after power-on
2019-01-15 8:10 ` Jan Kiszka
@ 2019-01-15 8:13 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2019-01-15 8:13 UTC (permalink / raw)
To: Jan Kiszka
Cc: John Stultz, Linux Kernel Mailing List, linux-arm-kernel, Wei Xu,
Ryan Grachek, linux-wireless, Reizer, Eyal, Valentin Schneider,
Tony Lindgren, Kalle Valo, KISHON VIJAY ABRAHAM, Mishol, Guy,
Anders Roxell, Ricardo Salveti
On Tue, 15 Jan 2019 at 09:10, Jan Kiszka <jan.kiszka@web.de> wrote:
>
> On 06.01.19 10:53, Jan Kiszka wrote:
> > On 03.01.19 22:32, Ulf Hansson wrote:
> >> On Wed, 2 Jan 2019 at 23:21, John Stultz <john.stultz@linaro.org> wrote:
> >>>
> >>> Adding a few folks to cc from the thread here:
> >>> https://patchwork.kernel.org/patch/10734021/
> >>>
> >>> As this sounds like a very similar issue.
> >>> thanks
> >>> -john
> >>
> >> John, thanks for looping me in.
> >>
> >>>
> >>> On Sun, Dec 30, 2018 at 3:38 AM Jan Kiszka <jan.kiszka@web.de> wrote:
> >>>>
> >>>> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>>>
> >>>> Somewhere along recent changes to power control of the wl1835, power-on
> >>>> became very unreliable on the hikey, failing like this:
> >>>>
> >>>> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> >>>> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
> >>>>
> >>>> After playing with some dt parameters and comparing to other users of
> >>>> this chip, it turned out we need some power-on delay to make things
> >>>> stable again. In contrast to those other users which define 200 ms, the
> >>>> hikey is already very happy with 1 ms.
> >>
> >> According to the discussions we had so far, this doesn't sound like
> >> the correct solution.
> >>
> >> I am intending to post patch soon, however, I am not sure exactly what
> >> solution to pick yet. I will keep you on cc - and of course I
> >> appreciate if you could help to test.
> >>
> >
> > FWIW, the Ultra96 is also affected. Here I worked around it by using a 10 ms
> > power-on delay. The original workaround from the other thread did not help.
> > Looking forward to the proper fix now!
> >
>
> Any news on this regression?
I will post a (or two) patch during the day.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-15 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-30 11:38 [PATCH] arm64: dts: hikey: Give wifi some time after power-on Jan Kiszka
2019-01-02 22:21 ` John Stultz
2019-01-03 21:32 ` Ulf Hansson
2019-01-06 9:53 ` Jan Kiszka
2019-01-15 8:10 ` Jan Kiszka
2019-01-15 8:13 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).