From: Ulf Hansson <ulf.hansson@linaro.org>
To: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Douglas Anderson <dianders@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Guenter Roeck <groeck@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Kalle Valo <kvalo@codeaurora.org>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/7] mmc: sdio: Various fixes/improvements for SDIO PM
Date: Thu, 20 Jun 2019 15:43:45 +0200 [thread overview]
Message-ID: <CAPDyKFqCyh7pZ3SFkxHZU+edBSHYx6V1LD-BdHBugmoSe+g2PQ@mail.gmail.com> (raw)
In-Reply-To: <20190618153448.27145-1-ulf.hansson@linaro.org>
On Tue, 18 Jun 2019 at 17:34, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> The power management support implemented via system suspend/resume and runtime
> suspend/resume for SDIO cards is rather messy, but also fragile.
>
> This series makes some improvement to this code. In particular the so called
> powered-on re-initialization of SDIO card is quite questionable, I suspect
> it may never really worked well. Therefore this series removes this code, which
> helps to prepare for additional improvements on top in a later series.
>
> So far the series has only been compile tested, so any help in testing on HW for
> regressions is greatly appreciated.
>
> Kind regards
> Uffe
>
> Ulf Hansson (7):
> mmc: sdio: Turn sdio_run_irqs() into static
> mmc: sdio: Drop mmc_claim|release_host() in mmc_sdio_power_restore()
> mmc: sdio: Move comment about re-initialization to
> mmc_sdio_reinit_card()
> mmc: sdio: Drop powered-on re-init at runtime resume and HW reset
> mmc: sdio: Don't re-initialize powered-on removable SDIO cards at
> resume
> mmc: sdio: Drop unused in-parameter to mmc_sdio_reinit_card()
> mmc: sdio: Drop unused in-parameter from mmc_sdio_init_card()
>
> drivers/mmc/core/sdio.c | 92 +++++++++++++++----------------------
> drivers/mmc/core/sdio_irq.c | 3 +-
> include/linux/mmc/host.h | 1 -
> 3 files changed, 38 insertions(+), 58 deletions(-)
>
> --
> 2.17.1
>
I decided to queue this up, to see what tests from linux-next and
kernelCI reports.
Still, that doesn't mean I am appreciating test done on HW. I can also
apply tested-by tags by amending patches after this point.
Kind regards
Uffe
prev parent reply other threads:[~2019-06-20 13:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 15:34 [PATCH 0/7] mmc: sdio: Various fixes/improvements for SDIO PM Ulf Hansson
2019-06-18 15:34 ` [PATCH 1/7] mmc: sdio: Turn sdio_run_irqs() into static Ulf Hansson
2019-06-19 0:17 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 2/7] mmc: sdio: Drop mmc_claim|release_host() in mmc_sdio_power_restore() Ulf Hansson
2019-07-09 21:25 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 3/7] mmc: sdio: Move comment about re-initialization to mmc_sdio_reinit_card() Ulf Hansson
2019-07-09 21:27 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 4/7] mmc: sdio: Drop powered-on re-init at runtime resume and HW reset Ulf Hansson
2019-07-04 0:01 ` Doug Anderson
2019-07-08 10:53 ` Ulf Hansson
2019-07-08 21:12 ` Doug Anderson
2019-07-09 12:01 ` Ulf Hansson
2019-07-09 23:35 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 5/7] mmc: sdio: Don't re-initialize powered-on removable SDIO cards at resume Ulf Hansson
2019-07-09 21:26 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 6/7] mmc: sdio: Drop unused in-parameter to mmc_sdio_reinit_card() Ulf Hansson
2019-07-09 21:29 ` Doug Anderson
2019-06-18 15:34 ` [PATCH 7/7] mmc: sdio: Drop unused in-parameter from mmc_sdio_init_card() Ulf Hansson
2019-07-09 21:31 ` Doug Anderson
2019-06-20 13:43 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqCyh7pZ3SFkxHZU+edBSHYx6V1LD-BdHBugmoSe+g2PQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=kvalo@codeaurora.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).