From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1884BC31E44 for ; Mon, 17 Jun 2019 07:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4AAD20449 for ; Mon, 17 Jun 2019 07:54:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rF1z+kGx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727231AbfFQHx7 (ORCPT ); Mon, 17 Jun 2019 03:53:59 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:33594 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbfFQHx7 (ORCPT ); Mon, 17 Jun 2019 03:53:59 -0400 Received: by mail-ua1-f65.google.com with SMTP id f20so3154321ual.0 for ; Mon, 17 Jun 2019 00:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tRW1fNYqfwgQBy9THQpXCwuo5cDKvcErh5obSg7YYNc=; b=rF1z+kGx4xXL8zfFmisXiiKRC1ok9357niHWA7JwibX0ET3Sg2Vx/C91G3nrLc+Xhe BPK1VcVetMEFD5keUYeTb5W3hxqOdM34b/M9bruL5im6NuFkKRqVC7jsMPkebP2tAn6Y D94jWFD4CUzmB3wQv0vDlpQdduzhIvtbUwbiHXA/jfeOFu2cvoIcibGdp+E+Bd3gGBoy 3gl7atT4pvqbvXUtPRwvJqQds1zAPHerPuoQw/wouC1cnIz0xBuv7d33qJEKP6bN2kwZ CNzBAvYinLErfw6BiZX1TKiSPZVm6+weN+Ve92dW+5Ee4stiJZG0x7ywBtwPHFq7QAAV g3Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tRW1fNYqfwgQBy9THQpXCwuo5cDKvcErh5obSg7YYNc=; b=P31WWL73PIuK0XgogdIvKkL2ICy05PwaMYD7nz9V9Dg19l30owaVQTuzkrbVeEzIHQ F+OGMFWlDbKkdx31z1JaFWp5Jqy18Ltvr6eFbMOJGl1aHWHWNCd138V8I+dea7Cqc9Mz dWLDJDqqMbx/CNpFzbDvZFz2+KB4l64ugF47/LhjwL36i4ZtYi7YySSC5D7rPkPHJbkC MN5kTnOePLvI3iuLV1Zk/jp+kNPO2nbrPlM5R2LxtZcriqwSy+p6rRCei9uVIYVrwxqh 2+lk/5LSwp5QGSIHqZ/avEp2I904++q05YwWqbhN93KhWWbW28QieENheL9M5vdrG48w pT0A== X-Gm-Message-State: APjAAAXntcr0sHyu12Y49X262p7tSWQcAU+18F5FRuDAUSNcwgkiKq5/ U3uG7BNZaAB1cpv5S1nHIIkUFoUIgfRZ3b0rJIcx2A== X-Google-Smtp-Source: APXvYqyhLV0eZUsbwyc8+v3TnW8XR69RoxoH9782ZqeCtf+IvVa1gMZ7SgjScvGxko8mmZpldj50C+TaD9ZWqmsljgk= X-Received: by 2002:a9f:31a2:: with SMTP id v31mr6656078uad.15.1560758038323; Mon, 17 Jun 2019 00:53:58 -0700 (PDT) MIME-Version: 1.0 References: <20190613234153.59309-1-dianders@chromium.org> <20190613234153.59309-3-dianders@chromium.org> In-Reply-To: From: Ulf Hansson Date: Mon, 17 Jun 2019 09:53:20 +0200 Message-ID: Subject: Re: [PATCH v4 2/5] mmc: core: API to temporarily disable retuning for SDIO CRC errors To: Doug Anderson Cc: Kalle Valo , Adrian Hunter , Arend van Spriel , brcm80211-dev-list.pdl@broadcom.com, "open list:ARM/Rockchip SoC..." , Double Lo , Brian Norris , linux-wireless , Naveen Gupta , Madhan Mohan R , Matthias Kaehlcke , Wright Feng , Chi-Hsien Lin , netdev , brcm80211-dev-list , Jiong Wu , Ritesh Harjani , Allison Randal , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , Thomas Gleixner , Greg Kroah-Hartman , Shawn Lin , Wolfram Sang , Avri Altman Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org [...] > > > --- a/include/linux/mmc/sdio_func.h > > > +++ b/include/linux/mmc/sdio_func.h > > > @@ -167,4 +167,7 @@ extern void sdio_f0_writeb(struct sdio_func *func, unsigned char b, > > > extern mmc_pm_flag_t sdio_get_host_pm_caps(struct sdio_func *func); > > > extern int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags); > > > > > > +extern void sdio_retune_crc_disable(struct sdio_func *func); > > > +extern void sdio_retune_crc_enable(struct sdio_func *func); > > > + > > > #endif /* LINUX_MMC_SDIO_FUNC_H */ > > > -- > > > 2.22.0.rc2.383.gf4fbbf30c2-goog > > > > > > > Besides the minor comments, this looks good to me. > > Thank you for the reviews! > > I'll plan to send a v5 on my Monday with the fixes assuming no new > heated discussion starts up. If it's less work for you, I'm also > happy if you just want to make the trivial fixes yourself when > applying. It really doesn't matter to me, feel free to pick the option you prefer. At this point I am just awaiting acks for the broadcom patces and some clarity of what stable releases we should target for non-tagged patches. Kind regards Uffe