linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Tony Lindgren <tony@atomide.com>, Eyal Reizer <eyalr@ti.com>,
	linux-wireless@vger.kernel.org,
	Ricardo Salveti <rsalveti@rsalveti.net>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Anders Roxell <anders.roxell@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Jan Kiszka <jan.kiszka@web.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH V2] wlcore: sdio: Fixup power on/off sequence
Date: Wed, 23 Jan 2019 09:52:46 +0100	[thread overview]
Message-ID: <CAPDyKFrSF0J7d7vM+RWFbS=Chn+pK6ur4xepCPGxnGXGajLRMg@mail.gmail.com> (raw)
In-Reply-To: <20190122162421.7F047609B4@smtp.codeaurora.org>

On Tue, 22 Jan 2019 at 17:24, Kalle Valo <kvalo@codeaurora.org> wrote:
>
> Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> > During "wlan-up", we are programming the FW into the WiFi-chip. However,
> > re-programming the FW doesn't work, unless a power cycle of the WiFi-chip
> > is made in-between the programmings.
> >
> > To conform to this requirement and to fix the regression in a simple way,
> > let's start by allowing that the SDIO card (WiFi-chip) may stay powered on
> > (runtime resumed) when wl12xx_sdio_power_off() returns. The intent with the
> > current code is to treat this scenario as an error, but unfortunate this
> > doesn't work as expected, so let's fix this.
> >
> > The other part is to guarantee that a power cycle of the SDIO card has been
> > completed when wl12xx_sdio_power_on() returns, as to allow the FW
> > programming to succeed. However, relying solely on runtime PM to deal with
> > this isn't sufficient. For example, userspace may prevent runtime suspend
> > via sysfs for the device that represents the SDIO card, leading to that the
> > mmc core also keeps it powered on. For this reason, let's instead do a
> > brute force power cycle in wl12xx_sdio_power_on().
> >
> > Fixes: 728a9dc61f13 ("wlcore: sdio: Fix flakey SDIO runtime PM handling")
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Tested-by: Tony Lindgren <tony@atomide.com>
> > Tested-by: Anders Roxell <anders.roxell@linaro.org>
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Patch applied to wireless-drivers.git, thanks.
>
> 13e62626c578 wlcore: sdio: Fixup power on/off sequence

Great, thanks! Let's see how we can fix Jan's problem on top.

Kind regards
Uffe

      parent reply	other threads:[~2019-01-23  8:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 11:37 [PATCH V2] wlcore: sdio: Fixup power on/off sequence Ulf Hansson
2019-01-16 15:43 ` Tony Lindgren
2019-01-16 15:48   ` Ulf Hansson
2019-01-16 16:18     ` Kalle Valo
2019-01-18 15:05   ` Anders Roxell
2019-01-18 15:36     ` Kalle Valo
2019-01-18 15:49       ` Tony Lindgren
2019-01-16 20:26 ` Jan Kiszka
2019-01-17  9:54   ` Ulf Hansson
2019-01-18 12:09     ` Jan Kiszka
2019-01-18 15:09       ` Ulf Hansson
2019-01-18 15:35         ` Tony Lindgren
2019-01-21 14:40         ` Ulf Hansson
2019-01-21 19:30           ` Tony Lindgren
2019-01-22 16:08           ` Jan Kiszka
2019-01-23  8:50             ` Ulf Hansson
2019-01-23 20:17               ` Jan Kiszka
2019-01-23 21:18                 ` Ulf Hansson
2019-01-22 16:24 ` Kalle Valo
     [not found] ` <20190122162421.7F047609B4@smtp.codeaurora.org>
2019-01-23  8:52   ` Ulf Hansson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPDyKFrSF0J7d7vM+RWFbS=Chn+pK6ur4xepCPGxnGXGajLRMg@mail.gmail.com' \
    --to=ulf.hansson@linaro.org \
    --cc=anders.roxell@linaro.org \
    --cc=eyalr@ti.com \
    --cc=jan.kiszka@web.de \
    --cc=john.stultz@linaro.org \
    --cc=kishon@ti.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rsalveti@rsalveti.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).