From: "Gao, Yunpeng" <yunpeng.gao@intel.com>
To: Ohad Ben-Cohen <ohad@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Luciano Coelho <luciano.coelho@nokia.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
Ido Yariv <ido@wizery.com>, San Mehat <san@google.com>,
Roger Quadros <roger.quadros@nokia.com>,
Nicolas Pitre <nico@fluxnic.net>
Subject: RE: [RFC/PATCH 3/6] mmc: add general runtime PM support
Date: Thu, 26 Aug 2010 17:42:00 +0800 [thread overview]
Message-ID: <CE761E84DADF2947A4AF22FB8D97A4732A516CE8@shsmsx501.ccr.corp.intel.com> (raw)
In-Reply-To: <1281532770-27545-4-git-send-email-ohad@wizery.com>
>>+static int mmc_runtime_suspend(struct device *dev)
>+{
>+ int status = 0;
>+ struct mmc_card *card = dev_to_mmc_card(dev);
>+
>+ mmc_power_save_host(card->host);
>+
>+ return status;
>+}
It seems the power_save callback is not implemented (Null pointer) yet for both mmc and sdio. Does it mean that the power_save callback will be implemented in future or just don't need at all? Thanks.
>+static int mmc_runtime_resume(struct device *dev)
>+{
>+ int status = 0;
>+ struct mmc_card *card = dev_to_mmc_card(dev);
>+
>+ mmc_power_restore_host(card->host);
>+
>+ return status;
>+}
>+
>+static int mmc_runtime_idle(struct device *dev)
>+{
>+ struct mmc_card *card = dev_to_mmc_card(dev);
>+
>+ return pm_runtime_suspend(dev);
>+}
>+
>+static const struct dev_pm_ops mmc_bus_pm_ops = {
>+ .runtime_suspend = mmc_runtime_suspend,
>+ .runtime_resume = mmc_runtime_resume,
>+ .runtime_idle = mmc_runtime_idle,
>+};
>+
> static struct bus_type mmc_bus_type = {
> .name = "mmc",
> .dev_attrs = mmc_dev_attrs,
>@@ -146,6 +180,7 @@ static struct bus_type mmc_bus_type = {
> .remove = mmc_bus_remove,
> .suspend = mmc_bus_suspend,
> .resume = mmc_bus_resume,
>+ .pm = &mmc_bus_pm_ops,
> };
>
I think this is a good example to implement runtime PM support for mmc driver. But seems it doesn't provide a runtime PM example on host controller driver side. To my understanding, once the functions (mmc card or sdio devices) and mmc/sdio bus enter into rumtime suspend, it should then make the host controller enter into runtime suspend, too. Any ideas on how to achieve this? Thanks.
Best Regards,
Yunpeng Gao
next prev parent reply other threads:[~2010-08-26 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 13:19 [RFC 0/6] adding SDIO Runtime PM support Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 1/6] mmc: sdio: fully reconfigure oldcard on resume Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 2/6] sdio: add power_restore support Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 3/6] mmc: add general runtime PM support Ohad Ben-Cohen
2010-08-26 9:42 ` Gao, Yunpeng [this message]
2010-09-01 20:08 ` Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 4/6] sdio: " Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 5/6] sdio: enable Runtime PM for SDIO cards Ohad Ben-Cohen
2010-08-11 13:19 ` [RFC/PATCH 6/6] wireless: wl1271_sdio: enable Runtime PM Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE761E84DADF2947A4AF22FB8D97A4732A516CE8@shsmsx501.ccr.corp.intel.com \
--to=yunpeng.gao@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ido@wizery.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).