From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, nbd@nbd.name,
"Thomas Hühn" <thomas.huehn@hs-nordhausen.de>
Subject: Re: [RFC 0/4] mac80211: add TPC support in control path
Date: Mon, 29 Aug 2022 17:06:20 +0200 [thread overview]
Message-ID: <CE871D89-B996-4D8B-8C65-7C53382C30D8@gmail.com> (raw)
In-Reply-To: <467218ec220ea6e36b4222efc5c46e4e350fe1ea.camel@sipsolutions.net>
We planned to get these changes upstream at first to have the foundation for TPC
in the mac80211, and then develop driver implementations and TPC algorithm on
top of this once all is reviewed, approved and upstream.
The ath9k tpc support is currently not upstream-ready but can be in a next version.
For testing the actual TPC support I modified minstrel’s debugfs to be able to set
fixed tx-power per STA.
I think we can develop this series further to come up with fully working driver
implementation and a TPC algorithm if you think that would be better.
Else we could also provide at least a debugfs patch to be able to set fixed
tx-power per STA.
Greetings
Jonas
> On 29. Aug 2022, at 16:46, Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Mon, 2022-08-29 at 16:41 +0200, Jonas Jelonek wrote:
>>
>> I tested the tx-power annotation with an implementation of TPC in ath9k
>> (not included in this RFC) and small changes in minstrel_ht for debugfs
>> access. Tx-power status report in ath9k required the proposed utility
>> function in mac80211.
>>
>
> Huh wait, now that I got to the end of the series ... this doesn't
> actually *do* anything, so what's the point? Shouldn't it come with some
> implementation of the control?
>
> johannes
next prev parent reply other threads:[~2022-08-29 15:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 14:41 [RFC 0/4] mac80211: add TPC support in control path Jonas Jelonek
2022-08-29 14:41 ` [RFC 1/4] mac80211: modify tx-power level annotation Jonas Jelonek
2022-08-29 14:41 ` [RFC 2/4] mac80211: add tx-power annotation in control path Jonas Jelonek
2022-08-29 14:41 ` [RFC 3/4] mac80211: add hardware flags for TPC support Jonas Jelonek
2022-08-29 14:41 ` [RFC 4/4] mac80211: add utility function for tx_rate - rate_info conversion Jonas Jelonek
2022-08-29 14:45 ` [RFC 0/4] mac80211: add TPC support in control path Johannes Berg
2022-08-29 14:51 ` Thomas Hühn
2022-08-29 14:52 ` Johannes Berg
2022-08-29 14:52 ` Johannes Berg
2022-08-29 15:19 ` Jonas Jelonek
2022-08-29 20:31 ` Thomas Hühn
2022-08-29 15:15 ` Jonas Jelonek
2022-08-29 14:46 ` Johannes Berg
2022-08-29 15:06 ` Jonas Jelonek [this message]
2022-08-31 13:59 ` Jonas Jelonek
2022-08-31 14:22 ` Johannes Berg
2022-08-31 15:39 ` Jonas Jelonek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE871D89-B996-4D8B-8C65-7C53382C30D8@gmail.com \
--to=jelonek.jonas@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=thomas.huehn@hs-nordhausen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).