RE: [kbuild-all] Re: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer

["Sang, Oliver" <oliver.sang@intel.com>]

> Kalle Valo <kvalo@codeaurora.org> writes:
> 
> >
> > + linux-wireless
> >
> > kbuild test robot <lkp@intel.com> writes:
> >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > > head:   e098d7762d602be640c53565ceca342f81e55ad2
> > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > rtw88:
> > > set power trim according to efuse PG values
> > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > reproduce:
> > >         git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > >         # save the attached .config to linux build tree
> > >         make ARCH=i386
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > >
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > 'rtw8822c_power_trim':
> > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > >> missing braces around initializer [-Wmissing-braces]
> > > s8 bb_gain[2][8] = {0};
> > > ^
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > > initialization for 'bb_gain[0]') [-Wmissing-braces]
> >
> > Tony, please check this and fix it. If it's a false warning please let
> > us know.
> >
> 
> I tried to re-pro by:
>          git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
>          # save the attached .config to linux build tree
>          make ARCH=i386
> 
> But cannot see it. And I checked the code, looks fine to me.
> It seems to be a false warning.

Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.

From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning should be only on old compilers.
If made below change, the warning will disappear.
@@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct rtw_dev *rtwdev, s8 bb_gain[2][8])
 static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
 {
        u8 pg_pwr = 0xff, i, path, idx;
-       s8 bb_gain[2][8] = {0};
+       s8 bb_gain[2][8] = {};
        u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};

Similar fix could be seen, as an example, on https://lkml.org/lkml/2017/9/12/159


> 
> Yen-Hsuan
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org To unsubscribe send an email to
> kbuild-all-leave@lists.01.org