* Re: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
[not found] <202005141308.j8dUPd66%lkp@intel.com>
@ 2020-05-18 12:24 ` Kalle Valo
2020-05-19 9:16 ` Tony Chuang
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2020-05-18 12:24 UTC (permalink / raw)
To: kbuild test robot
Cc: Tzu-En Huang, kbuild-all, Yan-Hsuan Chuang, linux-wireless
+ linux-wireless
kbuild test robot <lkp@intel.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: e098d7762d602be640c53565ceca342f81e55ad2
> commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703] rtw88:
> set power trim according to efuse PG values
> config: i386-randconfig-a002-20200514 (attached as .config)
> compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> reproduce:
> git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function 'rtw8822c_power_trim':
>>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
>> missing braces around initializer [-Wmissing-braces]
> s8 bb_gain[2][8] = {0};
> ^
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> initialization for 'bb_gain[0]') [-Wmissing-braces]
Tony, please check this and fix it. If it's a false warning please let
us know.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
2020-05-18 12:24 ` [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer Kalle Valo
@ 2020-05-19 9:16 ` Tony Chuang
2020-05-21 12:30 ` [kbuild-all] " Sang, Oliver
0 siblings, 1 reply; 5+ messages in thread
From: Tony Chuang @ 2020-05-19 9:16 UTC (permalink / raw)
To: Kalle Valo, kbuild test robot; +Cc: Andy Huang, kbuild-all, linux-wireless
Kalle Valo <kvalo@codeaurora.org> writes:
>
> + linux-wireless
>
> kbuild test robot <lkp@intel.com> writes:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master
> > head: e098d7762d602be640c53565ceca342f81e55ad2
> > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> rtw88:
> > set power trim according to efuse PG values
> > config: i386-randconfig-a002-20200514 (attached as .config)
> > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > reproduce:
> > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> 'rtw8822c_power_trim':
> >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> >> missing braces around initializer [-Wmissing-braces]
> > s8 bb_gain[2][8] = {0};
> > ^
> > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > initialization for 'bb_gain[0]') [-Wmissing-braces]
>
> Tony, please check this and fix it. If it's a false warning please let
> us know.
>
I tried to re-pro by:
git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
# save the attached .config to linux build tree
make ARCH=i386
But cannot see it. And I checked the code, looks fine to me.
It seems to be a false warning.
Yen-Hsuan
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [kbuild-all] Re: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
2020-05-19 9:16 ` Tony Chuang
@ 2020-05-21 12:30 ` Sang, Oliver
2020-05-22 3:49 ` Tony Chuang
0 siblings, 1 reply; 5+ messages in thread
From: Sang, Oliver @ 2020-05-21 12:30 UTC (permalink / raw)
To: Tony Chuang, Kalle Valo, lkp
Cc: Andy Huang, kbuild-all, linux-wireless, Sang, Oliver
> Kalle Valo <kvalo@codeaurora.org> writes:
>
> >
> > + linux-wireless
> >
> > kbuild test robot <lkp@intel.com> writes:
> >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > master
> > > head: e098d7762d602be640c53565ceca342f81e55ad2
> > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > rtw88:
> > > set power trim according to efuse PG values
> > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > reproduce:
> > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > # save the attached .config to linux build tree
> > > make ARCH=i386
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > >
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > 'rtw8822c_power_trim':
> > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > >> missing braces around initializer [-Wmissing-braces]
> > > s8 bb_gain[2][8] = {0};
> > > ^
> > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > > initialization for 'bb_gain[0]') [-Wmissing-braces]
> >
> > Tony, please check this and fix it. If it's a false warning please let
> > us know.
> >
>
> I tried to re-pro by:
> git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> # save the attached .config to linux build tree
> make ARCH=i386
>
> But cannot see it. And I checked the code, looks fine to me.
> It seems to be a false warning.
Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning should be only on old compilers.
If made below change, the warning will disappear.
@@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct rtw_dev *rtwdev, s8 bb_gain[2][8])
static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
{
u8 pg_pwr = 0xff, i, path, idx;
- s8 bb_gain[2][8] = {0};
+ s8 bb_gain[2][8] = {};
u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB, PPG_2GH_TXAB};
Similar fix could be seen, as an example, on https://lkml.org/lkml/2017/9/12/159
>
> Yen-Hsuan
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org To unsubscribe send an email to
> kbuild-all-leave@lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [kbuild-all] Re: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
2020-05-21 12:30 ` [kbuild-all] " Sang, Oliver
@ 2020-05-22 3:49 ` Tony Chuang
2020-05-23 11:31 ` Sang, Oliver
0 siblings, 1 reply; 5+ messages in thread
From: Tony Chuang @ 2020-05-22 3:49 UTC (permalink / raw)
To: Sang, Oliver, Kalle Valo, lkp; +Cc: Andy Huang, kbuild-all, linux-wireless
>
> > Kalle Valo <kvalo@codeaurora.org> writes:
> >
> > >
> > > + linux-wireless
> > >
> > > kbuild test robot <lkp@intel.com> writes:
> > >
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > master
> > > > head: e098d7762d602be640c53565ceca342f81e55ad2
> > > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > > rtw88:
> > > > set power trim according to efuse PG values
> > > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > > reproduce:
> > > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > > # save the attached .config to linux build tree
> > > > make ARCH=i386
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kbuild test robot <lkp@intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > > >
> > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > > 'rtw8822c_power_trim':
> > > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > >> missing braces around initializer [-Wmissing-braces]
> > > > s8 bb_gain[2][8] = {0};
> > > > ^
> > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: (near
> > > > initialization for 'bb_gain[0]') [-Wmissing-braces]
> > >
> > > Tony, please check this and fix it. If it's a false warning please let
> > > us know.
> > >
> >
> > I tried to re-pro by:
> > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > # save the attached .config to linux build tree
> > make ARCH=i386
> >
> > But cannot see it. And I checked the code, looks fine to me.
> > It seems to be a false warning.
>
> Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
>
> From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning
> should be only on old compilers.
> If made below change, the warning will disappear.
> @@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct
> rtw_dev *rtwdev, s8 bb_gain[2][8])
> static void rtw8822c_power_trim(struct rtw_dev *rtwdev)
> {
> u8 pg_pwr = 0xff, i, path, idx;
> - s8 bb_gain[2][8] = {0};
> + s8 bb_gain[2][8] = {};
> u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB,
> PPG_2GH_TXAB};
>
> Similar fix could be seen, as an example, on
> https://lkml.org/lkml/2017/9/12/159
>
Oh, my gcc version is 5.5.0 20171010.
OK, then I know it should be fixed for old gcc versions.
Thanks!
Yen-Hsuan
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [kbuild-all] Re: [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer
2020-05-22 3:49 ` Tony Chuang
@ 2020-05-23 11:31 ` Sang, Oliver
0 siblings, 0 replies; 5+ messages in thread
From: Sang, Oliver @ 2020-05-23 11:31 UTC (permalink / raw)
To: Tony Chuang, Kalle Valo, lkp; +Cc: Andy Huang, kbuild-all, linux-wireless
> From: Tony Chuang <yhchuang@realtek.com>
>
> >
> > > Kalle Valo <kvalo@codeaurora.org> writes:
> > >
> > > >
> > > > + linux-wireless
> > > >
> > > > kbuild test robot <lkp@intel.com> writes:
> > > >
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > > > master
> > > > > head: e098d7762d602be640c53565ceca342f81e55ad2
> > > > > commit: 5ad4d8957b69f3ebf95ac02212c388bda75aeb30 [2957/8703]
> > > > rtw88:
> > > > > set power trim according to efuse PG values
> > > > > config: i386-randconfig-a002-20200514 (attached as .config)
> > > > > compiler: gcc-4.9 (Ubuntu 4.9.3-13ubuntu2) 4.9.3
> > > > > reproduce:
> > > > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > > > # save the attached .config to linux build tree
> > > > > make ARCH=i386
> > > > >
> > > > > If you fix the issue, kindly add following tag as appropriate
> > > > > Reported-by: kbuild test robot <lkp@intel.com>
> > > > >
> > > > > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> > > > >
> > > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function
> > > > 'rtw8822c_power_trim':
> > > > >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > > >> missing braces around initializer [-Wmissing-braces]
> > > > > s8 bb_gain[2][8] = {0};
> > > > > ^
> > > > > drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning:
> > > > > (near initialization for 'bb_gain[0]') [-Wmissing-braces]
> > > >
> > > > Tony, please check this and fix it. If it's a false warning please
> > > > let us know.
> > > >
> > >
> > > I tried to re-pro by:
> > > git checkout 5ad4d8957b69f3ebf95ac02212c388bda75aeb30
> > > # save the attached .config to linux build tree
> > > make ARCH=i386
> > >
> > > But cannot see it. And I checked the code, looks fine to me.
> > > It seems to be a false warning.
> >
> > Hi, what's your compiler? we can reproduce by gcc-4.9 and follow above steps.
> >
> > From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 , the warning
> > should be only on old compilers.
> > If made below change, the warning will disappear.
> > @@ -1036,7 +1036,7 @@ static void rtw8822c_set_power_trim(struct
> > rtw_dev *rtwdev, s8 bb_gain[2][8]) static void
> > rtw8822c_power_trim(struct rtw_dev *rtwdev) {
> > u8 pg_pwr = 0xff, i, path, idx;
> > - s8 bb_gain[2][8] = {0};
> > + s8 bb_gain[2][8] = {};
> > u16 rf_efuse_2g[3] = {PPG_2GL_TXAB, PPG_2GM_TXAB,
> > PPG_2GH_TXAB};
> >
> > Similar fix could be seen, as an example, on
> > https://lkml.org/lkml/2017/9/12/159
> >
>
> Oh, my gcc version is 5.5.0 20171010.
> OK, then I know it should be fixed for old gcc versions.
> Thanks!
Thank you
>
> Yen-Hsuan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-23 11:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202005141308.j8dUPd66%lkp@intel.com>
2020-05-18 12:24 ` [linux-next:master 2957/8703] drivers/net/wireless/realtek/rtw88/rtw8822c.c:1039:2: warning: missing braces around initializer Kalle Valo
2020-05-19 9:16 ` Tony Chuang
2020-05-21 12:30 ` [kbuild-all] " Sang, Oliver
2020-05-22 3:49 ` Tony Chuang
2020-05-23 11:31 ` Sang, Oliver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).