From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E979C072B1 for ; Thu, 30 May 2019 05:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A7DA25F8C for ; Thu, 30 May 2019 05:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727478AbfE3FGE convert rfc822-to-8bit (ORCPT ); Thu, 30 May 2019 01:06:04 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:53272 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbfE3FGE (ORCPT ); Thu, 30 May 2019 01:06:04 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x4U55qKn030084, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtitcasv01.realtek.com.tw[172.21.6.18]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x4U55qKn030084 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NOT); Thu, 30 May 2019 13:05:52 +0800 Received: from RTITEXH01.realtek.com.tw (172.21.6.62) by RTITCASV01.realtek.com.tw (172.21.6.18) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 30 May 2019 13:05:52 +0800 Received: from RTITMBSVM04.realtek.com.tw ([fe80::e404:880:2ef1:1aa1]) by RTITEXH01.realtek.com.tw ([::1]) with mapi id 14.03.0439.000; Thu, 30 May 2019 13:05:52 +0800 From: Tony Chuang To: Kalle Valo CC: Larry Finger , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH 01/11] rtw88: resolve order of tx power setting routines Thread-Topic: [PATCH 01/11] rtw88: resolve order of tx power setting routines Thread-Index: AQHVFqR5j7cTtmsick2V2quSGI+CHaaDHN8Q Date: Thu, 30 May 2019 05:05:50 +0000 Message-ID: References: <1559116487-5244-1-git-send-email-yhchuang@realtek.com> <1559116487-5244-2-git-send-email-yhchuang@realtek.com> <87v9xspmfd.fsf@codeaurora.org> In-Reply-To: <87v9xspmfd.fsf@codeaurora.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.68.183] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > -----Original Message----- > From: Kalle Valo [mailto:kvalo@codeaurora.org] > Sent: Thursday, May 30, 2019 1:00 PM > To: Tony Chuang > Cc: Larry Finger; linux-wireless@vger.kernel.org > Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines > > Tony Chuang writes: > > >> -----Original Message----- > >> From: Larry Finger [mailto:larry.finger@gmail.com] On Behalf Of Larry > Finger > >> Sent: Wednesday, May 29, 2019 11:17 PM > >> To: Tony Chuang; kvalo@codeaurora.org > >> Cc: linux-wireless@vger.kernel.org > >> Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting > routines > >> > >> On 5/29/19 2:54 AM, yhchuang@realtek.com wrote: > >> > From: Yan-Hsuan Chuang > >> > > >> > Some functions that should be static are unnecessarily exposed, remove > >> > their declaration in header file phy.h. > >> > > >> > After resolving their declaration order, they can be declared as static. > >> > So this commit changes nothing except the order and marking them > static. > >> > > >> > Signed-off-by: Yan-Hsuan Chuang > >> > >> This patch does not apply. Using quilt to see what is wrong, there are 6 > >> changes > >> that have already been applied. > >> > >> Larry > >> > > > > > > These patches are based on > > > > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-dr > ivers > > branch master > > > > commit 6aca09771db4277a78853d6ac680d8d5f0d915e3 > > Author: YueHaibing > > Date: Sat May 4 18:32:24 2019 +0800 > > > > rtw88: Make some symbols static > > > > > > It should apply, did I miss something? > > I keep the bar high and take to wireless-drivers only patches which fix > important, user visible problems. Everything else goes to > wireless-drivers-next. So you should use wireless-drivers-next as the > baseline for all regular patches. Hi, Kalle But this series has dependency with " rtw88: Make some symbols static" Or you can handle it > > -- > Kalle Valo > Yan-Hsuan