linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Chuang <yhchuang@realtek.com>
To: Chris Chiu <chiu@endlessm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>
Subject: RE: [PATCH 2/2] rtw88: report RX power for each antenna
Date: Thu, 12 Sep 2019 07:43:15 +0000	[thread overview]
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D18D2D2B@RTITMBSVM04.realtek.com.tw> (raw)
In-Reply-To: <CAB4CAwde2ciT8AtYOXP3NJw=fq3uano_GQYXNKjcL+M+hKeWhA@mail.gmail.com>

> From: Chris Chiu 
> 
> On Thu, Sep 12, 2019 at 2:39 PM <yhchuang@realtek.com> wrote:
> >
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > Report chains and chain_signal in ieee80211_rx_status.
> > It is useful for program such as tcpdump to see if the
> > antennas are well connected/placed.
> >
> > 8822C is able to receive CCK rates with 2 antennas, while
> > 8822B can only use 1 antenna path to receive CCK rates.
> >
> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> > ---
> >  drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1 +
> >  drivers/net/wireless/realtek/rtw88/rtw8822c.c | 6 +++---
> >  drivers/net/wireless/realtek/rtw88/rx.c       | 5 +++++
> >  3 files changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> > index 568033a..0861195 100644
> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
> > @@ -766,6 +766,7 @@ static void query_phy_status_page0(struct rtw_dev
> *rtwdev, u8 *phy_status,
> >         s8 min_rx_power = -120;
> >         u8 pwdb = GET_PHY_STAT_P0_PWDB(phy_status);
> >
> > +       /* 8822B uses only 1 antenna to RX CCK rates */
> >         pkt_stat->rx_power[RF_PATH_A] = pwdb - 110;
> 
> It only uses PATH_A for receiving CCK rates packets? The comment seems
> not clear enough.
> 

Yes, it can only use PATH_A, so we don't have PWDB_[A|B] for 8822B.

Yan-Hsuan


  reply	other threads:[~2019-09-12  7:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  6:39 [PATCH 0/2] rtw88: report RX signal strength for each antenna yhchuang
2019-09-12  6:39 ` [PATCH 1/2] rtw88: fix wrong rx power calculation yhchuang
2019-09-12  7:05   ` Chris Chiu
2019-09-13 15:14   ` Kalle Valo
2019-09-12  6:39 ` [PATCH 2/2] rtw88: report RX power for each antenna yhchuang
2019-09-12  7:15   ` Chris Chiu
2019-09-12  7:43     ` Tony Chuang [this message]
2019-09-12  9:11       ` Chris Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F7CD281DE3E379468C6D07993EA72F84D18D2D2B@RTITMBSVM04.realtek.com.tw \
    --to=yhchuang@realtek.com \
    --cc=briannorris@chromium.org \
    --cc=chiu@endlessm.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).