linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ganapathi Bhat <gbhat@marvell.com>
To: "huangwenabc@gmail.com" <huangwenabc@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "amitkarwar@gmail.com" <amitkarwar@gmail.com>,
	"nishants@marvell.com" <nishants@marvell.com>,
	"huxinming820@gmail.com" <huxinming820@gmail.com>,
	"solar@openwall.com" <solar@openwall.com>,
	"greg@kroah.com" <greg@kroah.com>,
	"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"sashal@kernel.org" <sashal@kernel.org>,
	"mrehak@redhat.com" <mrehak@redhat.com>
Subject: RE: [EXT] [PATCH] mwifiex: Fix three heap overflow at parsing element in cfg80211_ap_settings
Date: Wed, 28 Aug 2019 03:01:38 +0000	[thread overview]
Message-ID: <MN2PR18MB2637246460C7C23764751498A0A30@MN2PR18MB2637.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190828020751.13625-1-huangwenabc@gmail.com>

Hi Wen Huang,

> mwifiex_update_vs_ie(),mwifiex_set_uap_rates() and
> mwifiex_set_wmm_params() call memcpy() without checking the destination
> size.Since the source is given from user-space, this may trigger a heap buffer
> overflow.
> 
> Fix them by putting the length check before performing memcpy().
> 
> This fix addresses CVE-2019-14814,CVE-2019-14815,CVE-2019-14816.

Thanks for the fix, this change looks good;

Acked-by: Ganapathi Bhat <gbhat@marvell.comg>

Regards,
Ganapathi

  reply	other threads:[~2019-08-28  3:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  2:07 [PATCH] mwifiex: Fix three heap overflow at parsing element in cfg80211_ap_settings huangwenabc
2019-08-28  3:01 ` Ganapathi Bhat [this message]
2019-08-28 20:36 ` Johannes Berg
2019-08-28 20:37   ` Johannes Berg
2019-09-03 13:50 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR18MB2637246460C7C23764751498A0A30@MN2PR18MB2637.namprd18.prod.outlook.com \
    --to=gbhat@marvell.com \
    --cc=amitkarwar@gmail.com \
    --cc=greg@kroah.com \
    --cc=huangwenabc@gmail.com \
    --cc=huxinming820@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mrehak@redhat.com \
    --cc=nishants@marvell.com \
    --cc=sashal@kernel.org \
    --cc=solar@openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).