From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-co1nam03on0107.outbound.protection.outlook.com ([104.47.40.107]:46809 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752865AbdGSUS2 (ORCPT ); Wed, 19 Jul 2017 16:18:28 -0400 From: Haiyang Zhang To: Andy Shevchenko , "linux-acpi@vger.kernel.org" , "devel@linuxdriverproject.org" , "sparmaintainer@unisys.com" , "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-efi@vger.kernel.org" , Christoph Hellwig , "linux-kernel@vger.kernel.org" , Lukas Wunner CC: KY Srinivasan , Stephen Hemminger Subject: RE: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API Date: Wed, 19 Jul 2017 20:18:24 +0000 Message-ID: (sfid-20170719_221846_832289_B17B4BD4) References: <20170719182857.73693-1-andriy.shevchenko@linux.intel.com> <20170719182857.73693-5-andriy.shevchenko@linux.intel.com> In-Reply-To: <20170719182857.73693-5-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com] > Sent: Wednesday, July 19, 2017 2:29 PM > To: linux-acpi@vger.kernel.org; devel@linuxdriverproject.org; > sparmaintainer@unisys.com; devel@driverdev.osuosl.org; linux- > wireless@vger.kernel.org; linux-watchdog@vger.kernel.org; linux- > efi@vger.kernel.org; Christoph Hellwig ; linux- > kernel@vger.kernel.org; Lukas Wunner > Cc: Andy Shevchenko ; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger > Subject: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API >=20 > @@ -118,8 +116,8 @@ enum hv_fcopy_op { >=20 > struct hv_fcopy_hdr { > __u32 operation; > - uuid_le service_id0; /* currently unused */ > - uuid_le service_id1; /* currently unused */ > + __u8 service_id0[16]; /* currently unused */ > + __u8 service_id1[16]; /* currently unused */ > } __attribute__((packed)); Even user space may not have all guid_t operations, could you still put guid_t here for consistency? This file is also used by our kernel mode code. Thanks, - Haiyang